leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

brcmfmac: Fix a double-free in brcmf_sdio_bus_reset

Browse Source 
brcmf_sdiod_remove has been called inside brcmf_sdiod_probe when fails,
so there's no need to call another one. Otherwise, sdiodev->freezer
would be double freed.

Fixes: 7836102a75 ("brcmfmac: reset SDIO bus on a firmware crash")
Signed-off-by: Tong Tiangen <tongtiangen@huawei.com>
Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210601100128.69561-1-tongtiangen@huawei.com
This commit is contained in:
Tong Tiangen 2021-06-01 18:01:28 +08:00 committed by Kalle Valo
parent ea3f903cae
commit 7ea7a1e05c
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
View File

@ -4162,7 +4162,6 @@ static int brcmf_sdio_bus_reset(struct device *dev)
if (ret) { if (ret) {
brcmf_err("Failed to probe after sdio device reset: ret %d\n", brcmf_err("Failed to probe after sdio device reset: ret %d\n",
ret); ret);
brcmf_sdiod_remove(sdiodev);
} }
return ret; return ret;