leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

staging: bcm2835-camera: Remove explicit cache flush operations

Browse Source 
The camera code has an explicit cache flush operation
which is not portable.  Now that vc04_services is using portable
DMA APIs that already do the cache flushing, explicit flushes
should no longer be needed.

The one call to __cpuc_flush_dcache_area has been removed.

Testing:
	The offical V2 camera for the RPI was tested on a RPI 3
	running in 32 bit mode(armhf).  The cheese application
	and ffmpeg was used to view and stream video from the
	camera.  Nothing new seems to be broken without the
	cache flushing.

Signed-off-by: Michael Zoran <mzoran@crowfest.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Michael Zoran 2017-03-08 04:21:51 -08:00 committed by Greg Kroah-Hartman
parent 5b6d458e87
commit 7e8dbea410
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
View File

@ -276,10 +276,6 @@ static int bulk_receive(struct vchiq_mmal_instance *instance,
msg_context->u.bulk.dts = msg->u.buffer_from_host.buffer_header.dts;
msg_context->u.bulk.pts = msg->u.buffer_from_host.buffer_header.pts;
// only need to flush L1 cache here, as VCHIQ takes care of the L2
// cache.
__cpuc_flush_dcache_area(msg_context->u.bulk.buffer->buffer, rd_len);
/* queue the bulk submission */
vchi_service_use(instance->handle);
ret = vchi_bulk_queue_receive(instance->handle,