leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mlxsw: core: Increase scope of RCU read-side critical section

Browse Source 
The lifetime of the Rx listener item ('rxl_item') is managed using RCU,
but is dereferenced outside of RCU read-side critical section, which can
lead to a use-after-free.

Fix this by increasing the scope of the RCU read-side critical section.

Fixes: 93c1edb27f ("mlxsw: Introduce Mellanox switch driver core")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Ido Schimmel 2020-07-29 12:26:45 +03:00 committed by David S. Miller
parent ec4f5b3617
commit 7d8e8f3433
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/ethernet/mellanox/mlxsw/core.c
View File

@ -2051,11 +2051,13 @@ void mlxsw_core_skb_receive(struct mlxsw_core *mlxsw_core, struct sk_buff *skb,
break; break;
} }
} }
rcu_read_unlock(); if (!found) {
if (!found) rcu_read_unlock();
goto drop; goto drop;
}
rxl->func(skb, local_port, rxl_item->priv); rxl->func(skb, local_port, rxl_item->priv);
rcu_read_unlock();
return; return;
drop: drop: