leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vc_screen: document and cleanup vcs_vc

Browse Source 
Document parameters of vcs_vc and make viewed a bool.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20200818085706.12163-4-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Jiri Slaby 2020-08-18 10:56:54 +02:00 committed by Greg Kroah-Hartman
parent b8209f694f
commit 7d62549a22
1 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
drivers/tty/vt/vc_screen.c
View File

@ -177,12 +177,14 @@ vcs_poll_data_get(struct file *file)
return poll; return poll;
} }
/* /**
* Returns VC for inode. * vcs_vc -- return VC for @inode
* @inode: inode for which to return a VC
* @viewed: returns whether this console is currently foreground (viewed)
*
* Must be called with console_lock. * Must be called with console_lock.
*/ */
static struct vc_data* static struct vc_data *vcs_vc(struct inode *inode, bool *viewed)
vcs_vc(struct inode *inode, int *viewed)
{ {
unsigned int currcons = console(inode); unsigned int currcons = console(inode);
@ -191,11 +193,11 @@ vcs_vc(struct inode *inode, int *viewed)
if (currcons == 0) { if (currcons == 0) {
currcons = fg_console; currcons = fg_console;
if (viewed) if (viewed)
*viewed = 1; *viewed = true;
} else { } else {
currcons--; currcons--;
if (viewed) if (viewed)
*viewed = 0; *viewed = false;
} }
return vc_cons[currcons].d; return vc_cons[currcons].d;
} }
@ -247,10 +249,11 @@ vcs_read(struct file *file, char __user *buf, size_t count, loff_t *ppos)
struct vc_data *vc; struct vc_data *vc;
struct vcs_poll_data *poll; struct vcs_poll_data *poll;
long pos, read; long pos, read;
int attr, uni_mode, row, col, maxcol, viewed; int attr, uni_mode, row, col, maxcol;
unsigned short *org = NULL; unsigned short *org = NULL;
ssize_t ret; ssize_t ret;
char *con_buf; char *con_buf;
bool viewed;
con_buf = (char *) __get_free_page(GFP_KERNEL); con_buf = (char *) __get_free_page(GFP_KERNEL);
if (!con_buf) if (!con_buf)
@ -451,10 +454,11 @@ vcs_write(struct file *file, const char __user *buf, size_t count, loff_t *ppos)
long pos; long pos;
long attr, size, written; long attr, size, written;
char *con_buf0; char *con_buf0;
int col, maxcol, viewed; int col, maxcol;
u16 *org0 = NULL, *org = NULL; u16 *org0 = NULL, *org = NULL;
size_t ret; size_t ret;
char *con_buf; char *con_buf;
bool viewed;
if (use_unicode(inode)) if (use_unicode(inode))
return -EOPNOTSUPP; return -EOPNOTSUPP;