leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drm/kirin: Checking for IS_ERR() instead of NULL

Browse Source 
The of_graph_get_remote_node() function doesn't return error pointers,
it returns NULL on error so I've updated the check.

Fixes: 86418f90a4 ("drm: convert drivers to use of_graph_get_remote_node")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20171005125751.jvtjms62vbtxuvak@mwanda
This commit is contained in:
Dan Carpenter 2017-10-05 15:57:51 +03:00 committed by Sean Paul
parent d9d7a3ef47
commit 7af35b0add
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
View File

@ -237,8 +237,8 @@ static int kirin_drm_platform_probe(struct platform_device *pdev)
} }
remote = of_graph_get_remote_node(np, 0, 0); remote = of_graph_get_remote_node(np, 0, 0);
if (IS_ERR(remote)) if (!remote)
return PTR_ERR(remote); return -ENODEV;
drm_of_component_match_add(dev, &match, compare_of, remote); drm_of_component_match_add(dev, &match, compare_of, remote);
of_node_put(remote); of_node_put(remote);