leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

scsi_dh_alua: remove 'rel_port' from alua_dh_data structure

Browse Source 
The 'relative port' field is not used, and might get stale when
the port group changes. So remove the field altogether.

Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Hannes Reinecke 2016-02-19 09:17:09 +01:00 committed by Martin K. Petersen
parent aa90f49036
commit 7af33612f4
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/scsi/device_handler/scsi_dh_alua.c
View File

@ -87,7 +87,6 @@ struct alua_port_group {
struct alua_dh_data { struct alua_dh_data {
struct alua_port_group *pg; struct alua_port_group *pg;
int group_id; int group_id;
int rel_port;
struct scsi_device *sdev; struct scsi_device *sdev;
activate_complete callback_fn; activate_complete callback_fn;
void *callback_data; void *callback_data;
@ -325,12 +324,10 @@ static int alua_check_vpd(struct scsi_device *sdev, struct alua_dh_data *h,
return SCSI_DH_NOMEM; return SCSI_DH_NOMEM;
return SCSI_DH_DEV_UNSUPP; return SCSI_DH_DEV_UNSUPP;
} }
h->rel_port = rel_port;
sdev_printk(KERN_INFO, sdev, sdev_printk(KERN_INFO, sdev,
"%s: device %s port group %x rel port %x\n", "%s: device %s port group %x rel port %x\n",
ALUA_DH_NAME, h->pg->device_id_str, ALUA_DH_NAME, h->pg->device_id_str,
h->group_id, h->rel_port); h->group_id, rel_port);
return alua_rtpg(sdev, h->pg); return alua_rtpg(sdev, h->pg);
} }
@ -762,7 +759,6 @@ static int alua_bus_attach(struct scsi_device *sdev)
if (!h) if (!h)
return -ENOMEM; return -ENOMEM;
h->pg = NULL; h->pg = NULL;
h->rel_port = -1;
h->sdev = sdev; h->sdev = sdev;
err = alua_initialize(sdev, h); err = alua_initialize(sdev, h);