leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[SCSI] scsi_dh: suppress comparison warning

Browse Source 
On Mon, 2008-09-22 at 14:56 -0700, akpm@linux-foundation.org wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
>
> s390:
>
> drivers/scsi/device_handler/scsi_dh_emc.c: In function 'parse_sp_info_reply':
> drivers/scsi/device_handler/scsi_dh_emc.c:179: warning: comparison is always false due to limited range of data type
>
> because chars are unsigned, I assume.

Fix by making csdev->buffer explicitly an unsigned char and dropping
the < 0 test.

Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
This commit is contained in:
James Bottomley 2008-09-23 07:58:59 -07:00
parent 650849d71c
commit 7ae628d9d2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/scsi/device_handler/scsi_dh_emc.c
View File

@ -84,7 +84,7 @@ struct clariion_dh_data {
/* /*
* I/O buffer for both MODE_SELECT and INQUIRY commands. * I/O buffer for both MODE_SELECT and INQUIRY commands.
*/ */
char buffer[CLARIION_BUFFER_SIZE]; unsigned char buffer[CLARIION_BUFFER_SIZE];
/* /*
* SCSI sense buffer for commands -- assumes serial issuance * SCSI sense buffer for commands -- assumes serial issuance
* and completion sequence of all commands for same multipath. * and completion sequence of all commands for same multipath.
@ -176,7 +176,7 @@ static int parse_sp_info_reply(struct scsi_device *sdev,
err = SCSI_DH_DEV_TEMP_BUSY; err = SCSI_DH_DEV_TEMP_BUSY;
goto out; goto out;
} }
if (csdev->buffer[4] < 0 || csdev->buffer[4] > 2) { if (csdev->buffer[4] > 2) {
/* Invalid buffer format */ /* Invalid buffer format */
sdev_printk(KERN_NOTICE, sdev, sdev_printk(KERN_NOTICE, sdev,
"%s: invalid VPD page 0xC0 format\n", "%s: invalid VPD page 0xC0 format\n",