leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mips: cavium-octeon: Fix missing of_node_put() in octeon2_usb_clocks_start

Browse Source 
We should call of_node_put() for the reference 'uctl_node' returned by
of_get_parent() which will increase the refcount. Otherwise, there will
be a refcount leak bug.

Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
This commit is contained in:
Liang He 2022-07-01 20:41:12 +08:00 committed by Thomas Bogendoerfer
parent 5f7e2f3e7c
commit 7a9f743cee
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
arch/mips/cavium-octeon/octeon-platform.c
View File

@ -86,11 +86,12 @@ static void octeon2_usb_clocks_start(struct device *dev)
"refclk-frequency", &clock_rate); "refclk-frequency", &clock_rate);
if (i) { if (i) {
dev_err(dev, "No UCTL \"refclk-frequency\"\n"); dev_err(dev, "No UCTL \"refclk-frequency\"\n");
of_node_put(uctl_node);
goto exit; goto exit;
} }
i = of_property_read_string(uctl_node, i = of_property_read_string(uctl_node,
"refclk-type", &clock_type); "refclk-type", &clock_type);
of_node_put(uctl_node);
if (!i && strcmp("crystal", clock_type) == 0) if (!i && strcmp("crystal", clock_type) == 0)
is_crystal_clock = true; is_crystal_clock = true;
} }