leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gpio: thunderx: fix error return code in thunderx_gpio_probe()

Browse Source 
Fix to return error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 5a2a30024d ("gpio: Add gpio driver support for ThunderX and OCTEON-TX")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: David Daney <david.daney@cavium.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Wei Yongjun
2018-01-10 14:37:13 +00:00
committed by Linus Walleij
parent 92a8046c9d
commit 76e28f5ffe
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpio/gpio-thunderx.c
View File

@@ -553,8 +553,10 @@ static int thunderx_gpio_probe(struct pci_dev *pdev,
txgpio->irqd = irq_domain_create_hierarchy(irq_get_irq_data(txgpio->msix_entries[0].vector)->domain, txgpio->irqd = irq_domain_create_hierarchy(irq_get_irq_data(txgpio->msix_entries[0].vector)->domain,
0, 0, of_node_to_fwnode(dev->of_node), 0, 0, of_node_to_fwnode(dev->of_node),
&thunderx_gpio_irqd_ops, txgpio); &thunderx_gpio_irqd_ops, txgpio);
if (!txgpio->irqd) if (!txgpio->irqd) {
err = -ENOMEM;
goto out; goto out;
}
/* Push on irq_data and the domain for each line. */ /* Push on irq_data and the domain for each line. */
for (i = 0; i < ngpio; i++) { for (i = 0; i < ngpio; i++) {