leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drm/i915/guc: Don't go bang in GuC log if no GuC

Browse Source 
If the GuC has failed to load for any reason and then the user pokes
the debugfs GuC log interface, a BUG and/or null pointer deref can
occur. Don't let that happen.

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20211210044022.1842938-5-John.C.Harrison@Intel.com
This commit is contained in:
John Harrison 2021-12-09 20:40:22 -08:00
parent 3d832f370d
commit 76aee8658b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpu/drm/i915/gt/uc/intel_guc_log_debugfs.c
View File

@ -31,7 +31,7 @@ static int guc_log_level_get(void *data, u64 *val)
{
struct intel_guc_log *log = data;
if (!intel_guc_is_used(log_to_guc(log)))
if (!log->vma)
return -ENODEV;
*val = intel_guc_log_get_level(log);
@ -43,7 +43,7 @@ static int guc_log_level_set(void *data, u64 val)
{
struct intel_guc_log *log = data;
if (!intel_guc_is_used(log_to_guc(log)))
if (!log->vma)
return -ENODEV;
return intel_guc_log_set_level(log, val);