media: staging/media/bcm2048: remove driver
This driver has seen no substantial effort to move it out of staging for 6 years. And after asking around nobody stepped up to do the remaining work. So remove it. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
This commit is contained in:
parent
79e85d1d2c
commit
757c2bf597
@ -22,8 +22,6 @@ if STAGING_MEDIA && MEDIA_SUPPORT
|
||||
# Please keep them in alphabetic order
|
||||
source "drivers/staging/media/allegro-dvt/Kconfig"
|
||||
|
||||
source "drivers/staging/media/bcm2048/Kconfig"
|
||||
|
||||
source "drivers/staging/media/davinci_vpfe/Kconfig"
|
||||
|
||||
source "drivers/staging/media/hantro/Kconfig"
|
||||
|
@ -1,6 +1,5 @@
|
||||
# SPDX-License-Identifier: GPL-2.0
|
||||
obj-$(CONFIG_VIDEO_ALLEGRO_DVT) += allegro-dvt/
|
||||
obj-$(CONFIG_I2C_BCM2048) += bcm2048/
|
||||
obj-$(CONFIG_VIDEO_IMX_MEDIA) += imx/
|
||||
obj-$(CONFIG_VIDEO_DM365_VPFE) += davinci_vpfe/
|
||||
obj-$(CONFIG_VIDEO_MESON_VDEC) += meson/vdec/
|
||||
|
@ -1,14 +0,0 @@
|
||||
# SPDX-License-Identifier: GPL-2.0
|
||||
#
|
||||
# Multimedia Video device configuration
|
||||
#
|
||||
|
||||
config I2C_BCM2048
|
||||
tristate "Broadcom BCM2048 FM Radio Receiver support"
|
||||
depends on I2C && VIDEO_V4L2 && RADIO_ADAPTERS
|
||||
help
|
||||
Say Y here if you want support to BCM2048 FM Radio Receiver.
|
||||
This device driver supports only i2c bus.
|
||||
|
||||
To compile this driver as a module, choose M here: the
|
||||
module will be called radio-bcm2048.
|
@ -1,2 +0,0 @@
|
||||
# SPDX-License-Identifier: GPL-2.0
|
||||
obj-$(CONFIG_I2C_BCM2048) += radio-bcm2048.o
|
@ -1,24 +0,0 @@
|
||||
TODO:
|
||||
|
||||
From the initial code review:
|
||||
|
||||
The main thing you need to do is to implement all the controls using the
|
||||
control framework (see Documentation/media/kapi/v4l2-controls.rst).
|
||||
Most drivers are by now converted to the control framework, so you will
|
||||
find many examples of how to do this in drivers/media/radio.
|
||||
|
||||
The sysfs stuff should be replaced by controls as well. A lot of the RDS
|
||||
support is now available as controls (although there may well be some
|
||||
missing features, but that is easy enough to add). Since the RDS data is
|
||||
actually read() from the device I am not sure whether the RDS
|
||||
properties/controls should be there at all.
|
||||
|
||||
Correct Coding Style, as this driver also violates several Style
|
||||
rules, and do evil tricks, like returning from a function inside a
|
||||
macro.
|
||||
|
||||
Finally this driver should probably be split up into two parts: one
|
||||
v4l2_subdev-based core driver and one platform driver. See e.g.
|
||||
radio-si4713/si4713-i2c.c as a good example. But I would wait with that
|
||||
until the rest of the driver is cleaned up. Then I have a better idea of
|
||||
whether this is necessary or not.
|
File diff suppressed because it is too large
Load Diff
@ -1,26 +0,0 @@
|
||||
/* SPDX-License-Identifier: GPL-2.0 */
|
||||
/*
|
||||
* drivers/staging/media/radio-bcm2048.h
|
||||
*
|
||||
* Property and command definitions for bcm2048 radio receiver chip.
|
||||
*
|
||||
* Copyright (C) Nokia Corporation
|
||||
* Contact: Eero Nurkkala <ext-eero.nurkkala@nokia.com>
|
||||
*
|
||||
* This program is free software; you can redistribute it and/or
|
||||
* modify it under the terms of the GNU General Public License
|
||||
* version 2 as published by the Free Software Foundation.
|
||||
*
|
||||
* This program is distributed in the hope that it will be useful, but
|
||||
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
||||
* General Public License for more details.
|
||||
*/
|
||||
|
||||
#ifndef BCM2048_H
|
||||
#define BCM2048_H
|
||||
|
||||
#define BCM2048_NAME "bcm2048"
|
||||
#define BCM2048_I2C_ADDR 0x22
|
||||
|
||||
#endif /* ifndef BCM2048_H */
|
Loading…
Reference in New Issue
Block a user