leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf_counter tools: Clean up u64 usage

Browse Source 
A build error slipped in:

 builtin-report.c: In function ‘hist_entry__fprintf’:
 builtin-report.c:711: error: format ‘%12d’ expects type ‘int’, but argument 3 has type ‘uint64_t’

Because we got a bit sloppy with those types. uint64_t really sucks,
because there's no printf format for it. So standardize on __u64
instead - for all types that go to or come from the ABI (which is __u64),
or for values that need to be large enough even on 32-bit.

Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
Ingo Molnar
2009-06-11 14:16:15 +02:00
parent df58ab24bf
commit 729ff5e2aa
6 changed files with 47 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tools/perf/builtin-top.c
View File

@@ -79,8 +79,8 @@ static int dump_symtab;
* Symbols
*/
static uint64_t min_ip;
static uint64_t max_ip = -1ll;
static __u64 min_ip;
static __u64 max_ip = -1ll;
struct sym_entry {
struct rb_node rb_node;
@@ -372,7 +372,7 @@ out_delete_dso:
/*
* Binary search in the histogram table and record the hit:
*/
static void record_ip(uint64_t ip, int counter)
static void record_ip(__u64 ip, int counter)
{
struct symbol *sym = dso__find_symbol(kernel_dso, ip);
@@ -392,7 +392,7 @@ static void record_ip(uint64_t ip, int counter)
samples--;
}
static void process_event(uint64_t ip, int counter)
static void process_event(__u64 ip, int counter)
{
samples++;