leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drm/panfrost: Remove type name from internal structs

Browse Source 
The two structs internal to struct panfrost_dump_object_header were
named, but sadly that is incompatible with C++, causing an error: "an
anonymous union may only have public non-static data members".

However nothing refers to struct pan_reg_hdr and struct pan_bomap_hdr
and there's no need to export these definitions, so lets drop them. This
fixes the C++ build error with the minimum change in userspace API.

Reported-by: Adrián Larumbe <adrian.larumbe@collabora.com>
Fixes: 730c2bf4ad ("drm/panfrost: Add support for devcoredump")
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Signed-off-by: Steven Price <steven.price@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221017104602.142992-2-steven.price@arm.com
This commit is contained in:
Steven Price 2022-10-17 11:46:01 +01:00
parent a91e5e3e22
commit 7228d9d792
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/uapi/drm/panfrost_drm.h
View File

@ -242,7 +242,7 @@ struct panfrost_dump_object_header {
__le32 file_offset; __le32 file_offset;
union { union {
struct pan_reg_hdr { struct {
__le64 jc; __le64 jc;
__le32 gpu_id; __le32 gpu_id;
__le32 major; __le32 major;
@ -250,7 +250,7 @@ struct panfrost_dump_object_header {
__le64 nbos; __le64 nbos;
} reghdr; } reghdr;
struct pan_bomap_hdr { struct {
__le32 valid; __le32 valid;
__le64 iova; __le64 iova;
__le32 data[2]; __le32 data[2];