leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

media: platform: Remove unnecessary print function dev_err()

Browse Source 
The print function dev_err() is redundant because platform_get_irq()
already prints an error.

Eliminate the follow coccicheck warnings:
./drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c:119:2-9:
line 119 is redundant because platform_get_irq() already prints an error
./drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_hw.c:103:2-9:
line 103 is redundant because platform_get_irq() already prints an error

Link: https://lore.kernel.org/linux-media/20220316001411.80167-1-yang.lee@linux.alibaba.com
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
This commit is contained in:
Yang Li 2022-03-16 01:14:11 +01:00 committed by Mauro Carvalho Chehab
parent 5d1ca13802
commit 71e6d0608e
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
View File

@ -115,10 +115,8 @@ static int mtk_vcodec_init_dec_resources(struct mtk_vcodec_dev *dev)
return 0;
dev->dec_irq = platform_get_irq(pdev, 0);
if (dev->dec_irq < 0) {
dev_err(&pdev->dev, "failed to get irq number");
if (dev->dec_irq < 0)
return dev->dec_irq;
}
irq_set_status_flags(dev->dec_irq, IRQ_NOAUTOEN);
ret = devm_request_irq(&pdev->dev, dev->dec_irq,

4
drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_hw.c
View File

@ -101,10 +101,8 @@ static int mtk_vdec_hw_init_irq(struct mtk_vdec_hw_dev *dev)
int ret;
dev->dec_irq = platform_get_irq(pdev, 0);
if (dev->dec_irq < 0) {
dev_err(&pdev->dev, "Failed to get irq resource");
if (dev->dec_irq < 0)
return dev->dec_irq;
}
irq_set_status_flags(dev->dec_irq, IRQ_NOAUTOEN);
ret = devm_request_irq(&pdev->dev, dev->dec_irq,