leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

staging: kpc2000: clean up after probe failure.

Browse Source 
On error, kp2000_probe_cores just returned an error without freeing
resources which had previously been allocated.  Added the missing
clean-up code.

Updated TODO.

Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Jeremy Sowden 2019-05-15 12:14:37 +01:00 committed by Greg Kroah-Hartman
parent abb611d2c2
commit 70eb40836c
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/staging/kpc2000/TODO
View File

@ -1,7 +1,6 @@
- the kpc_spi driver doesn't seem to let multiple transactions (to different instances of the core) happen in parallel...
- The kpc_i2c driver is a hot mess, it should probably be cleaned up a ton. It functions against current hardware though.
- pcard->card_num in kp2000_pcie_probe() is a global variable and needs atomic / locking / something better.
- the loop in kp2000_probe_cores() that uses probe_core_uio() also probably needs error handling
- would be nice if the AIO fileops in kpc_dma could be made to work
- probably want to add a CONFIG_ option to control compilation of the AIO functions
- if the AIO fileops in kpc_dma start working, next would be making iov_count > 1 work too

9
drivers/staging/kpc2000/kpc2000/cell_probe.c
View File

@ -438,7 +438,7 @@ int kp2000_probe_cores(struct kp2000_device *pcard)
dev_err(&pcard->pdev->dev,
"kp2000_probe_cores: failed to add core %d: %d\n",
i, err);
return err;
goto error;
}
core_num++;
}
@ -457,10 +457,15 @@ int kp2000_probe_cores(struct kp2000_device *pcard)
err = probe_core_uio(0, pcard, "kpc_uio", cte);
if (err){
dev_err(&pcard->pdev->dev, "kp2000_probe_cores: failed to add board_info core: %d\n", err);
return err;
goto error;
}
return 0;
error:
kp2000_remove_cores(pcard);
mfd_remove_devices(PCARD_TO_DEV(pcard));
return err;
}
void kp2000_remove_cores(struct kp2000_device *pcard)