leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mm/damon/dbgfs: remove an unnecessary variable

Browse Source 
Patch series "mm/damon: Hide unnecessary information disclosures".

DAMON is exposing some unnecessary information including kernel pointer
in kernel log and tracepoint.  This patchset hides such information.
The first patch is only for a trivial cleanup, though.

This patch (of 4):

This commit removes a unnecessarily used variable in
dbgfs_target_ids_write().

Link: https://lkml.kernel.org/r/20211229131016.23641-1-sj@kernel.org
Link: https://lkml.kernel.org/r/20211229131016.23641-2-sj@kernel.org
Fixes: 4bc05954d0 ("mm/damon: implement a debugfs-based user space interface")
Signed-off-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
SeongJae Park 2022-01-14 14:10:41 -08:00 committed by Linus Torvalds
parent 2cd4b8e10c
commit 70b8480812
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
mm/damon/dbgfs.c
View File

@ -364,7 +364,7 @@ static ssize_t dbgfs_target_ids_write(struct file *file,
struct damon_ctx *ctx = file->private_data; struct damon_ctx *ctx = file->private_data;
struct damon_target *t, *next_t; struct damon_target *t, *next_t;
bool id_is_pid = true; bool id_is_pid = true;
char *kbuf, *nrs; char *kbuf;
unsigned long *targets; unsigned long *targets;
ssize_t nr_targets; ssize_t nr_targets;
ssize_t ret; ssize_t ret;
@ -374,14 +374,13 @@ static ssize_t dbgfs_target_ids_write(struct file *file,
if (IS_ERR(kbuf)) if (IS_ERR(kbuf))
return PTR_ERR(kbuf); return PTR_ERR(kbuf);
nrs = kbuf;
if (!strncmp(kbuf, "paddr\n", count)) { if (!strncmp(kbuf, "paddr\n", count)) {
id_is_pid = false; id_is_pid = false;
/* target id is meaningless here, but we set it just for fun */ /* target id is meaningless here, but we set it just for fun */
scnprintf(kbuf, count, "42 "); scnprintf(kbuf, count, "42 ");
} }
targets = str_to_target_ids(nrs, count, &nr_targets); targets = str_to_target_ids(kbuf, count, &nr_targets);
if (!targets) { if (!targets) {
ret = -ENOMEM; ret = -ENOMEM;
goto out; goto out;