leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pwm: visconti: Simplify using devm_pwmchip_add()

Browse Source 
This allows to drop the platform_driver's remove function. This is the
only user of driver data so this can go away, too.

Signed-off-by: zhaoxiao <long870912@gmail.com>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
This commit is contained in:
zhaoxiao
2021-09-13 14:15:53 +08:00
committed by Thierry Reding
parent 06dfae38d9
commit 6facd84083
1 changed files with 1 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/pwm/pwm-visconti.c
View File

@@ -144,28 +144,17 @@ static int visconti_pwm_probe(struct platform_device *pdev)
if (IS_ERR(priv->base)) if (IS_ERR(priv->base))
return PTR_ERR(priv->base); return PTR_ERR(priv->base);
platform_set_drvdata(pdev, priv);
priv->chip.dev = dev; priv->chip.dev = dev;
priv->chip.ops = &visconti_pwm_ops; priv->chip.ops = &visconti_pwm_ops;
priv->chip.npwm = 4; priv->chip.npwm = 4;
ret = pwmchip_add(&priv->chip); ret = devm_pwmchip_add(&pdev->dev, &priv->chip);
if (ret < 0) if (ret < 0)
return dev_err_probe(&pdev->dev, ret, "Cannot register visconti PWM\n"); return dev_err_probe(&pdev->dev, ret, "Cannot register visconti PWM\n");
return 0; return 0;
} }
static int visconti_pwm_remove(struct platform_device *pdev)
{
struct visconti_pwm_chip *priv = platform_get_drvdata(pdev);
pwmchip_remove(&priv->chip);
return 0;
}
static const struct of_device_id visconti_pwm_of_match[] = { static const struct of_device_id visconti_pwm_of_match[] = {
{ .compatible = "toshiba,visconti-pwm", }, { .compatible = "toshiba,visconti-pwm", },
{ } { }
@@ -178,7 +167,6 @@ static struct platform_driver visconti_pwm_driver = {
.of_match_table = visconti_pwm_of_match, .of_match_table = visconti_pwm_of_match,
}, },
.probe = visconti_pwm_probe, .probe = visconti_pwm_probe,
.remove = visconti_pwm_remove,
}; };
module_platform_driver(visconti_pwm_driver); module_platform_driver(visconti_pwm_driver);