leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[PATCH] acenic: fix checking of read_eeprom_byte() return values

Browse Source 
tmp in ace_init is u32 thus rendering read_eeprom_byte() return values
checks useless.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
This commit is contained in:
Eric Sesterhenn 2006-01-20 23:32:56 +03:00 committed by Jeff Garzik
parent 6a986ce45d
commit 6f9d47220e
1 changed files with 4 additions and 0 deletions

4
drivers/net/acenic.c
View File

@ -1002,6 +1002,8 @@ static int __devinit ace_init(struct net_device *dev)
mac1 = 0; mac1 = 0;
for(i = 0; i < 4; i++) { for(i = 0; i < 4; i++) {
int tmp;
mac1 = mac1 << 8; mac1 = mac1 << 8;
tmp = read_eeprom_byte(dev, 0x8c+i); tmp = read_eeprom_byte(dev, 0x8c+i);
if (tmp < 0) { if (tmp < 0) {
@ -1012,6 +1014,8 @@ static int __devinit ace_init(struct net_device *dev)
} }
mac2 = 0; mac2 = 0;
for(i = 4; i < 8; i++) { for(i = 4; i < 8; i++) {
int tmp;
mac2 = mac2 << 8; mac2 = mac2 << 8;
tmp = read_eeprom_byte(dev, 0x8c+i); tmp = read_eeprom_byte(dev, 0x8c+i);
if (tmp < 0) { if (tmp < 0) {