leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

firewire: fw-sbp2: correctly dereference by container_of

Browse Source 
Replace a cast with a container_of().  As long as nobody reorders the
structure elements, they do the same thing, but container_of() is more
readable.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> (added complete_command_orb)
Acked-by: Kristian Høgsberg <krh@redhat.com>
This commit is contained in:
Jay Fenlason 2007-06-27 16:04:33 -04:00 committed by Stefan Richter
parent 7ada60e367
commit 6f061487f7
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/firewire/fw-sbp2.c
View File

@ -395,7 +395,7 @@ static void
complete_management_orb(struct sbp2_orb *base_orb, struct sbp2_status *status) complete_management_orb(struct sbp2_orb *base_orb, struct sbp2_status *status)
{ {
struct sbp2_management_orb *orb = struct sbp2_management_orb *orb =
(struct sbp2_management_orb *)base_orb; container_of(base_orb, struct sbp2_management_orb, base);
if (status) if (status)
memcpy(&orb->status, status, sizeof(*status)); memcpy(&orb->status, status, sizeof(*status));
@ -838,7 +838,8 @@ sbp2_status_to_sense_data(u8 *sbp2_status, u8 *sense_data)
static void static void
complete_command_orb(struct sbp2_orb *base_orb, struct sbp2_status *status) complete_command_orb(struct sbp2_orb *base_orb, struct sbp2_status *status)
{ {
struct sbp2_command_orb *orb = (struct sbp2_command_orb *)base_orb; struct sbp2_command_orb *orb =
container_of(base_orb, struct sbp2_command_orb, base);
struct fw_unit *unit = orb->unit; struct fw_unit *unit = orb->unit;
struct fw_device *device = fw_device(unit->device.parent); struct fw_device *device = fw_device(unit->device.parent);
struct scatterlist *sg; struct scatterlist *sg;