leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Input: mxs-lradc - use correct error check

Browse Source 
Function devm_ioremap() will return a NULL pointer on failure. However,
in function mxs_lradc_ts_probe(), its return value is checked with
IS_ERR(), which cannot detect the exceptional case.

Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
This commit is contained in:
Pan Bian 2017-08-14 10:29:13 -07:00 committed by Dmitry Torokhov
parent e48060ce2c
commit 6ecd36d732
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/input/touchscreen/mxs-lradc-ts.c
View File

@ -633,8 +633,8 @@ static int mxs_lradc_ts_probe(struct platform_device *pdev)
if (!iores) if (!iores)
return -EINVAL; return -EINVAL;
ts->base = devm_ioremap(dev, iores->start, resource_size(iores)); ts->base = devm_ioremap(dev, iores->start, resource_size(iores));
if (IS_ERR(ts->base)) if (!ts->base)
return PTR_ERR(ts->base); return -ENOMEM;
ret = of_property_read_u32(node, "fsl,lradc-touchscreen-wires", ret = of_property_read_u32(node, "fsl,lradc-touchscreen-wires",
&ts_wires); &ts_wires);