leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IB/core: sysfs.c: Fix PerfMgt ClassPortInfo handling

Browse Source 
Port number is not part of ClassPortInfo attribute but is
still needed as a parameter when invoking process_mad.

To properly handle this attribute, port_num is added as a
parameter to get_counter_table and get_perf_mad was changed
not to store port_num in the attribute itself when it's
querying the ClassPortInfo attribute.

This handles issue pointed out by Matan Barak <matanb@dev.mellanox.co.il>

Fixes: 145d9c5410 ('IB/core: Display extended counter set if available')

Signed-off-by: Hal Rosenstock <hal@mellanox.com>
Acked-by: Matan Barak <matanb@mellanox.com>
Acked-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Christoph Lameter <cl@linux.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
This commit is contained in:
Hal Rosenstock 2015-12-29 05:43:43 -05:00 committed by Doug Ledford
parent b6aeb980f1
commit 6e2a51a0f7
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/infiniband/core/sysfs.c
View File

@ -438,6 +438,7 @@ static int get_perf_mad(struct ib_device *dev, int port_num, __be16 attr,
in_mad->mad_hdr.method = IB_MGMT_METHOD_GET; in_mad->mad_hdr.method = IB_MGMT_METHOD_GET;
in_mad->mad_hdr.attr_id = attr; in_mad->mad_hdr.attr_id = attr;
if (attr != IB_PMA_CLASS_PORT_INFO)
in_mad->data[41] = port_num; /* PortSelect field */ in_mad->data[41] = port_num; /* PortSelect field */
if ((dev->process_mad(dev, IB_MAD_IGNORE_MKEY, if ((dev->process_mad(dev, IB_MAD_IGNORE_MKEY,
@ -714,11 +715,12 @@ err:
* Figure out which counter table to use depending on * Figure out which counter table to use depending on
* the device capabilities. * the device capabilities.
*/ */
static struct attribute_group *get_counter_table(struct ib_device *dev) static struct attribute_group *get_counter_table(struct ib_device *dev,
int port_num)
{ {
struct ib_class_port_info cpi; struct ib_class_port_info cpi;
if (get_perf_mad(dev, 0, IB_PMA_CLASS_PORT_INFO, if (get_perf_mad(dev, port_num, IB_PMA_CLASS_PORT_INFO,
&cpi, 40, sizeof(cpi)) >= 0) { &cpi, 40, sizeof(cpi)) >= 0) {
if (cpi.capability_mask && IB_PMA_CLASS_CAP_EXT_WIDTH) if (cpi.capability_mask && IB_PMA_CLASS_CAP_EXT_WIDTH)
@ -776,7 +778,7 @@ static int add_port(struct ib_device *device, int port_num,
goto err_put; goto err_put;
} }
p->pma_table = get_counter_table(device); p->pma_table = get_counter_table(device, port_num);
ret = sysfs_create_group(&p->kobj, p->pma_table); ret = sysfs_create_group(&p->kobj, p->pma_table);
if (ret) if (ret)
goto err_put_gid_attrs; goto err_put_gid_attrs;