leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

s390/qeth: remove check for packing mode in qeth_check_outbound_queue()

Browse Source 
If qeth_check_outbound_queue() finds a partially filled TX buffer on
the queue and flushes it, then the queue _must_ have been in packing
mode.

Remove the redundant check when updating the relevant statistics.

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Reviewed-by: Alexandra Winter <wintera@linux.ibm.com>
Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Julian Wiedmann
2021-12-07 10:04:52 +01:00
committed by Jakub Kicinski
parent 1b9e410f45
commit 6dc490e80c
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/s390/net/qeth_core_main.c
View File

@@ -3635,12 +3635,10 @@ static void qeth_check_outbound_queue(struct qeth_qdio_out_q *queue)
if ((atomic_read(&queue->used_buffers) <= QETH_LOW_WATERMARK_PACK) || if ((atomic_read(&queue->used_buffers) <= QETH_LOW_WATERMARK_PACK) ||
!atomic_read(&queue->set_pci_flags_count)) { !atomic_read(&queue->set_pci_flags_count)) {
unsigned int index, flush_cnt; unsigned int index, flush_cnt;
bool q_was_packing;
spin_lock(&queue->lock); spin_lock(&queue->lock);
index = queue->next_buf_to_fill; index = queue->next_buf_to_fill;
q_was_packing = queue->do_pack;
flush_cnt = qeth_switch_to_nonpacking_if_needed(queue); flush_cnt = qeth_switch_to_nonpacking_if_needed(queue);
if (!flush_cnt && !atomic_read(&queue->set_pci_flags_count)) if (!flush_cnt && !atomic_read(&queue->set_pci_flags_count))
@@ -3648,8 +3646,7 @@ static void qeth_check_outbound_queue(struct qeth_qdio_out_q *queue)
if (flush_cnt) { if (flush_cnt) {
qeth_flush_buffers(queue, index, flush_cnt); qeth_flush_buffers(queue, index, flush_cnt);
if (q_was_packing) QETH_TXQ_STAT_ADD(queue, bufs_pack, flush_cnt);
QETH_TXQ_STAT_ADD(queue, bufs_pack, flush_cnt);
} }
spin_unlock(&queue->lock); spin_unlock(&queue->lock);