leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net/mlx4: Add reference counting to MAC registeration

Browse Source 
Add reference counting to the driver MAC registeration code. This would
be needed for cases where a mac is registered from more than once, e.g
when both the host and the VM driver register the same mac, the host
for mac spoof protection purposes and the VM for its regular needs.

Signed-off-by: Rony Efraim <ronye@mellanox.com>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Rony Efraim 2013-04-25 05:22:25 +00:00 committed by David S. Miller
parent dc8142ea89
commit 6ce71acdea
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/net/ethernet/mellanox/mlx4/port.c
View File

@ -141,8 +141,9 @@ int __mlx4_register_mac(struct mlx4_dev *dev, u8 port, u64 mac)
} }
if (mac == (MLX4_MAC_MASK & be64_to_cpu(table->entries[i]))) { if (mac == (MLX4_MAC_MASK & be64_to_cpu(table->entries[i]))) {
/* MAC already registered, Must not have duplicates */ /* MAC already registered, increment ref count */
err = -EEXIST; err = i;
++table->refs[i];
goto out; goto out;
} }
} }
@ -165,7 +166,7 @@ int __mlx4_register_mac(struct mlx4_dev *dev, u8 port, u64 mac)
table->entries[free] = 0; table->entries[free] = 0;
goto out; goto out;
} }
table->refs[free] = 1;
err = free; err = free;
++table->total; ++table->total;
out: out:
@ -206,12 +207,16 @@ void __mlx4_unregister_mac(struct mlx4_dev *dev, u8 port, u64 mac)
struct mlx4_mac_table *table = &info->mac_table; struct mlx4_mac_table *table = &info->mac_table;
int index; int index;
index = find_index(dev, table, mac);
mutex_lock(&table->mutex); mutex_lock(&table->mutex);
index = find_index(dev, table, mac);
if (validate_index(dev, table, index)) if (validate_index(dev, table, index))
goto out; goto out;
if (--table->refs[index]) {
mlx4_dbg(dev, "Have more references for index %d,"
"no need to modify mac table\n", index);
goto out;
}
table->entries[index] = 0; table->entries[index] = 0;
mlx4_set_port_mac_table(dev, port, table->entries); mlx4_set_port_mac_table(dev, port, table->entries);