leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PCI: Check the node argument passed to cpumask_of_node

Browse Source 
Commit e0cd516 "PCI: derive nearby CPUs from device's instead of bus'
NUMA information" causes an null pointer dereference when reading from
the sysfs attributes local_cpu* on Intel machines with no ACPI NUMA
proximity info, since dev->numa_node gets set to -1 for all PCI devices,
which then gets passed to cpumask_of_node.

Add a check to prevent this.

Signed-off-by: David John <davidjon@xenontk.org>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
This commit is contained in:
David John 2010-01-04 20:28:57 +05:30 committed by Jesse Barnes
parent 46256f83d0
commit 6be954d1f9
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/pci/pci-sysfs.c
View File

@ -75,7 +75,8 @@ static ssize_t local_cpus_show(struct device *dev,
int len; int len;
#ifdef CONFIG_NUMA #ifdef CONFIG_NUMA
mask = cpumask_of_node(dev_to_node(dev)); mask = (dev_to_node(dev) == -1) ? cpu_online_mask :
cpumask_of_node(dev_to_node(dev));
#else #else
mask = cpumask_of_pcibus(to_pci_dev(dev)->bus); mask = cpumask_of_pcibus(to_pci_dev(dev)->bus);
#endif #endif
@ -93,7 +94,8 @@ static ssize_t local_cpulist_show(struct device *dev,
int len; int len;
#ifdef CONFIG_NUMA #ifdef CONFIG_NUMA
mask = cpumask_of_node(dev_to_node(dev)); mask = (dev_to_node(dev) == -1) ? cpu_online_mask :
cpumask_of_node(dev_to_node(dev));
#else #else
mask = cpumask_of_pcibus(to_pci_dev(dev)->bus); mask = cpumask_of_pcibus(to_pci_dev(dev)->bus);
#endif #endif