leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drm/mgag200: Add separate move-cursor function

Browse Source 
Adding mgag200_move_cursor() makes the cursor code more consistent and
will become handy when we move to universal cursor planes.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190927091301.10574-4-tzimmermann@suse.de
This commit is contained in:
Thomas Zimmermann 2019-09-27 11:12:57 +02:00
parent 49b8d5aeaf
commit 6ae04536e7
1 changed files with 20 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
drivers/gpu/drm/mgag200/mgag200_cursor.c
View File

@ -25,6 +25,24 @@ static void mgag200_hide_cursor(struct mga_device *mdev)
mdev->cursor.pixels_current = NULL; mdev->cursor.pixels_current = NULL;
} }
static void mgag200_move_cursor(struct mga_device *mdev, int x, int y)
{
if (WARN_ON(x <= 0))
return;
if (WARN_ON(y <= 0))
return;
if (WARN_ON(x & ~0xffff))
return;
if (WARN_ON(y & ~0xffff))
return;
WREG8(MGA_CURPOSXL, x & 0xff);
WREG8(MGA_CURPOSXH, (x>>8) & 0xff);
WREG8(MGA_CURPOSYL, y & 0xff);
WREG8(MGA_CURPOSYH, (y>>8) & 0xff);
}
int mgag200_cursor_init(struct mga_device *mdev) int mgag200_cursor_init(struct mga_device *mdev)
{ {
struct drm_device *dev = mdev->dev; struct drm_device *dev = mdev->dev;
@ -252,19 +270,12 @@ err_drm_gem_object_put_unlocked:
int mgag200_crtc_cursor_move(struct drm_crtc *crtc, int x, int y) int mgag200_crtc_cursor_move(struct drm_crtc *crtc, int x, int y)
{ {
struct mga_device *mdev = (struct mga_device *)crtc->dev->dev_private; struct mga_device *mdev = (struct mga_device *)crtc->dev->dev_private;
/* Our origin is at (64,64) */ /* Our origin is at (64,64) */
x += 64; x += 64;
y += 64; y += 64;
BUG_ON(x <= 0); mgag200_move_cursor(mdev, x, y);
BUG_ON(y <= 0);
BUG_ON(x & ~0xffff);
BUG_ON(y & ~0xffff);
WREG8(MGA_CURPOSXL, x & 0xff);
WREG8(MGA_CURPOSXH, (x>>8) & 0xff);
WREG8(MGA_CURPOSYL, y & 0xff);
WREG8(MGA_CURPOSYH, (y>>8) & 0xff);
return 0; return 0;
} }