leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nl80211: Handle nla_memdup failures in handle_nan_filter

Browse Source 
As there's potential for failure of the nla_memdup(),
check the return value.

Fixes: a442b761b2 ("cfg80211: add add_nan_func / del_nan_func")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Link: https://lore.kernel.org/r/20220301100020.3801187-1-jiasheng@iscas.ac.cn
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
This commit is contained in:
Jiasheng Jiang 2022-03-01 18:00:20 +08:00 committed by Johannes Berg
parent 5a6248c0a2
commit 6ad27f522c
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
net/wireless/nl80211.c
View File

@ -13411,6 +13411,9 @@ static int handle_nan_filter(struct nlattr *attr_filter,
i = 0; i = 0;
nla_for_each_nested(attr, attr_filter, rem) { nla_for_each_nested(attr, attr_filter, rem) {
filter[i].filter = nla_memdup(attr, GFP_KERNEL); filter[i].filter = nla_memdup(attr, GFP_KERNEL);
if (!filter[i].filter)
goto err;
filter[i].len = nla_len(attr); filter[i].len = nla_len(attr);
i++; i++;
} }
@ -13423,6 +13426,15 @@ static int handle_nan_filter(struct nlattr *attr_filter,
} }
return 0; return 0;
err:
i = 0;
nla_for_each_nested(attr, attr_filter, rem) {
kfree(filter[i].filter);
i++;
}
kfree(filter);
return -ENOMEM;
} }
static int nl80211_nan_add_func(struct sk_buff *skb, static int nl80211_nan_add_func(struct sk_buff *skb,