leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hwmon: (adm9240) Drop log messages from detect function

Browse Source 
Not detecting a chip in the detect function is normal and should not
generate any log messages, much less error messages.

Cc: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Tested-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Guenter Roeck 2021-03-10 20:11:54 -08:00
parent 1e28eed176
commit 69698bde18
1 changed files with 5 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/hwmon/adm9240.c
View File

@ -730,26 +730,19 @@ static int adm9240_detect(struct i2c_client *new_client,
return -ENODEV; return -ENODEV;
/* verify chip: reg address should match i2c address */ /* verify chip: reg address should match i2c address */
if (i2c_smbus_read_byte_data(new_client, ADM9240_REG_I2C_ADDR) if (i2c_smbus_read_byte_data(new_client, ADM9240_REG_I2C_ADDR) != address)
!= address) {
dev_err(&adapter->dev, "detect fail: address match, 0x%02x\n",
address);
return -ENODEV; return -ENODEV;
}
/* check known chip manufacturer */ /* check known chip manufacturer */
man_id = i2c_smbus_read_byte_data(new_client, ADM9240_REG_MAN_ID); man_id = i2c_smbus_read_byte_data(new_client, ADM9240_REG_MAN_ID);
if (man_id == 0x23) { if (man_id == 0x23)
name = "adm9240"; name = "adm9240";
} else if (man_id == 0xda) { else if (man_id == 0xda)
name = "ds1780"; name = "ds1780";
} else if (man_id == 0x01) { else if (man_id == 0x01)
name = "lm81"; name = "lm81";
} else { else
dev_err(&adapter->dev, "detect fail: unknown manuf, 0x%02x\n",
man_id);
return -ENODEV; return -ENODEV;
}
/* successful detect, print chip info */ /* successful detect, print chip info */
die_rev = i2c_smbus_read_byte_data(new_client, ADM9240_REG_DIE_REV); die_rev = i2c_smbus_read_byte_data(new_client, ADM9240_REG_DIE_REV);