leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

x86, numa: Fix numa emulation calculation of big nodes

Browse Source 
numa=fake=N uses split_nodes_interleave() to partition the system into N
fake nodes.  Each node size must have be a multiple of
FAKE_NODE_MIN_SIZE, otherwise it is possible to get strange alignments.
Because of this, the remaining memory from each node when rounded to
FAKE_NODE_MIN_SIZE is consolidated into a number of "big nodes" that are
bigger than the rest.

The calculation of the number of big nodes is incorrect since it is using
a logical AND operator when it should be multiplying the rounded-off
portion of each node with N.

Signed-off-by: David Rientjes <rientjes@google.com>
LKML-Reference: <alpine.DEB.2.00.1002151342230.26927@chino.kir.corp.google.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
This commit is contained in:
David Rientjes 2010-02-15 13:43:25 -08:00 committed by H. Peter Anvin
parent 0271f91003
commit 68fd111e02
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
arch/x86/mm/numa_64.c
View File

@ -427,7 +427,7 @@ static int __init split_nodes_interleave(u64 addr, u64 max_addr,
* Calculate the number of big nodes that can be allocated as a result * Calculate the number of big nodes that can be allocated as a result
* of consolidating the remainder. * of consolidating the remainder.
*/ */
big = ((size & ~FAKE_NODE_MIN_HASH_MASK) & nr_nodes) / big = ((size & ~FAKE_NODE_MIN_HASH_MASK) * nr_nodes) /
FAKE_NODE_MIN_SIZE; FAKE_NODE_MIN_SIZE;
size &= FAKE_NODE_MIN_HASH_MASK; size &= FAKE_NODE_MIN_HASH_MASK;