leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Staging: hv: warn the world of a bug in the release function

Browse Source 
All device release functions need to do something, if not, it's a bug.
By merely providing an "empty" release function, it gets the kernel to
shut up, but that's not solving the problem at all.  Stick a big fat
WARN_ON(1); in there to get people's attention.


Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Greg Kroah-Hartman 2009-09-01 20:12:58 -07:00
parent f4266e3425
commit 689bf40682
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/staging/hv/vmbus_drv.c
View File

@ -965,6 +965,11 @@ Desc: Final callback release of the vmbus root device
static void vmbus_bus_release(struct device *device) static void vmbus_bus_release(struct device *device)
{ {
DPRINT_ENTER(VMBUS_DRV); DPRINT_ENTER(VMBUS_DRV);
/* FIXME */
/* Empty release functions are a bug, or a major sign
* of a problem design, this MUST BE FIXED! */
dev_err(device, "%s needs to be fixed!\n", __func__);
WARN_ON(1);
DPRINT_EXIT(VMBUS_DRV); DPRINT_EXIT(VMBUS_DRV);
} }