leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Drivers: char: misc: 'misc_deregister()' changed the 'mutex_unlock' logic upon an error

Browse Source 
This change improves code readability & is less error-prone.
For example: case adding more error paths one should remember to call 'mutex_unlock'

Signed-off-by: Elad Wexler <elad.wexler@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Elad Wexler 2013-09-14 18:02:11 +03:00 committed by Greg Kroah-Hartman
parent bbf831dfe8
commit 684116caa4
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/char/misc.c
View File

@ -193,8 +193,8 @@ int misc_register(struct miscdevice * misc)
if (misc->minor == MISC_DYNAMIC_MINOR) { if (misc->minor == MISC_DYNAMIC_MINOR) {
int i = find_first_zero_bit(misc_minors, DYNAMIC_MINORS); int i = find_first_zero_bit(misc_minors, DYNAMIC_MINORS);
if (i >= DYNAMIC_MINORS) { if (i >= DYNAMIC_MINORS) {
mutex_unlock(&misc_mtx); err = -EBUSY;
return -EBUSY; goto out;
} }
misc->minor = DYNAMIC_MINORS - i - 1; misc->minor = DYNAMIC_MINORS - i - 1;
set_bit(i, misc_minors); set_bit(i, misc_minors);
@ -203,8 +203,8 @@ int misc_register(struct miscdevice * misc)
list_for_each_entry(c, &misc_list, list) { list_for_each_entry(c, &misc_list, list) {
if (c->minor == misc->minor) { if (c->minor == misc->minor) {
mutex_unlock(&misc_mtx); err = -EBUSY;
return -EBUSY; goto out;
} }
} }
} }