leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mfd: Fix off-by-one value range checking for tps65912_i2c_write

Browse Source 
If bytes == (TPS6591X_MAX_REGISTER + 1), we have a buffer overflow when
doing memcpy(&msg[1], src, bytes).

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
This commit is contained in:
Axel Lin 2011-06-24 15:34:16 +08:00 committed by Samuel Ortiz
parent a5e06781f0
commit 63c8a58d22
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/mfd/tps65912-i2c.c
View File

@ -57,7 +57,7 @@ static int tps65912_i2c_write(struct tps65912 *tps65912, u8 reg,
u8 msg[TPS6591X_MAX_REGISTER + 1];
int ret;
if (bytes > (TPS6591X_MAX_REGISTER + 1))
if (bytes > TPS6591X_MAX_REGISTER)
return -EINVAL;
msg[0] = reg;