leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

xen-netback: fix debugfs entry creation

Browse Source 
The original code is bogus. The function gets called in a loop which
leaks entries created in previous rounds.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Cc: Zoltan Kiss <zoltan.kiss@citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Wei Liu 2014-08-12 11:59:30 +01:00 committed by David S. Miller
parent 5c807005fa
commit 628fa76b09
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/net/xen-netback/xenbus.c
View File

@ -174,10 +174,9 @@ static const struct file_operations xenvif_dbg_io_ring_ops_fops = {
.write = xenvif_write_io_ring, .write = xenvif_write_io_ring,
}; };
static void xenvif_debugfs_addif(struct xenvif_queue *queue) static void xenvif_debugfs_addif(struct xenvif *vif)
{ {
struct dentry *pfile; struct dentry *pfile;
struct xenvif *vif = queue->vif;
int i; int i;
if (IS_ERR_OR_NULL(xen_netback_dbg_root)) if (IS_ERR_OR_NULL(xen_netback_dbg_root))
@ -736,11 +735,12 @@ static void connect(struct backend_info *be)
be->vif->num_queues = queue_index; be->vif->num_queues = queue_index;
goto err; goto err;
} }
#ifdef CONFIG_DEBUG_FS
xenvif_debugfs_addif(queue);
#endif /* CONFIG_DEBUG_FS */
} }
#ifdef CONFIG_DEBUG_FS
xenvif_debugfs_addif(be->vif);
#endif /* CONFIG_DEBUG_FS */
/* Initialisation completed, tell core driver the number of /* Initialisation completed, tell core driver the number of
* active queues. * active queues.
*/ */