leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: Fix data-races around netdev_tstamp_prequeue.

Browse Source 
While reading netdev_tstamp_prequeue, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its readers.

Fixes: 3b098e2d7c ("net: Consistent skb timestamping")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Kuniyuki Iwashima 2022-08-23 10:46:47 -07:00 committed by David S. Miller
parent 5dcd08cd19
commit 61adf447e3
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
net/core/dev.c
View File

@ -4928,7 +4928,7 @@ static int netif_rx_internal(struct sk_buff *skb)
{ {
int ret; int ret;
net_timestamp_check(netdev_tstamp_prequeue, skb); net_timestamp_check(READ_ONCE(netdev_tstamp_prequeue), skb);
trace_netif_rx(skb); trace_netif_rx(skb);
@ -5281,7 +5281,7 @@ static int __netif_receive_skb_core(struct sk_buff **pskb, bool pfmemalloc,
int ret = NET_RX_DROP; int ret = NET_RX_DROP;
__be16 type; __be16 type;
net_timestamp_check(!netdev_tstamp_prequeue, skb); net_timestamp_check(!READ_ONCE(netdev_tstamp_prequeue), skb);
trace_netif_receive_skb(skb); trace_netif_receive_skb(skb);
@ -5664,7 +5664,7 @@ static int netif_receive_skb_internal(struct sk_buff *skb)
{ {
int ret; int ret;
net_timestamp_check(netdev_tstamp_prequeue, skb); net_timestamp_check(READ_ONCE(netdev_tstamp_prequeue), skb);
if (skb_defer_rx_timestamp(skb)) if (skb_defer_rx_timestamp(skb))
return NET_RX_SUCCESS; return NET_RX_SUCCESS;
@ -5694,7 +5694,7 @@ void netif_receive_skb_list_internal(struct list_head *head)
INIT_LIST_HEAD(&sublist); INIT_LIST_HEAD(&sublist);
list_for_each_entry_safe(skb, next, head, list) { list_for_each_entry_safe(skb, next, head, list) {
net_timestamp_check(netdev_tstamp_prequeue, skb); net_timestamp_check(READ_ONCE(netdev_tstamp_prequeue), skb);
skb_list_del_init(skb); skb_list_del_init(skb);
if (!skb_defer_rx_timestamp(skb)) if (!skb_defer_rx_timestamp(skb))
list_add_tail(&skb->list, &sublist); list_add_tail(&skb->list, &sublist);