leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: igc: use skb_csum_is_sctp instead of protocol check

Browse Source 
Using skb_csum_is_sctp is a easier way to validate it's a SCTP CRC
checksum offload packet, and yet it also makes igc support SCTP
CRC checksum offload for UDP and GRE encapped packets, just as it
does in igb driver.

Signed-off-by: Xin Long <lucien.xin@gmail.com>
Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Xin Long
2021-01-16 14:13:40 +08:00
committed by Jakub Kicinski
parent d2de44443c
commit 609d29a9d2
1 changed files with 1 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/net/ethernet/intel/igc/igc_main.c
View File

@@ -949,15 +949,6 @@ static void igc_tx_ctxtdesc(struct igc_ring *tx_ring,
} }
} }
static inline bool igc_ipv6_csum_is_sctp(struct sk_buff *skb)
{
unsigned int offset = 0;
ipv6_find_hdr(skb, &offset, IPPROTO_SCTP, NULL, NULL);
return offset == skb_checksum_start_offset(skb);
}
static void igc_tx_csum(struct igc_ring *tx_ring, struct igc_tx_buffer *first) static void igc_tx_csum(struct igc_ring *tx_ring, struct igc_tx_buffer *first)
{ {
struct sk_buff *skb = first->skb; struct sk_buff *skb = first->skb;
@@ -980,10 +971,7 @@ csum_failed:
break; break;
case offsetof(struct sctphdr, checksum): case offsetof(struct sctphdr, checksum):
/* validate that this is actually an SCTP request */ /* validate that this is actually an SCTP request */
if ((first->protocol == htons(ETH_P_IP) && if (skb_csum_is_sctp(skb)) {
(ip_hdr(skb)->protocol == IPPROTO_SCTP)) ||
(first->protocol == htons(ETH_P_IPV6) &&
igc_ipv6_csum_is_sctp(skb))) {
type_tucmd = IGC_ADVTXD_TUCMD_L4T_SCTP; type_tucmd = IGC_ADVTXD_TUCMD_L4T_SCTP;
break; break;
} }