leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

powerpc/qe: Use strlcpy()

Browse Source 
Replace strcpy and strncpy with strlcpy to avoid strings that are too
big, or lack null termination.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
[scottwood@freescale.com: cleaned up commit message]
Signed-off-by: Scott Wood <scottwood@freescale.com>
This commit is contained in:
Rickard Strandqvist 2014-07-26 23:26:51 +02:00 committed by Scott Wood
parent 8ac6e995ac
commit 5db431285d
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
arch/powerpc/sysdev/qe_lib/qe.c
View File

@ -497,7 +497,7 @@ int qe_upload_firmware(const struct qe_firmware *firmware)
* saved microcode information and put in the new. * saved microcode information and put in the new.
*/ */
memset(&qe_firmware_info, 0, sizeof(qe_firmware_info)); memset(&qe_firmware_info, 0, sizeof(qe_firmware_info));
strcpy(qe_firmware_info.id, firmware->id); strlcpy(qe_firmware_info.id, firmware->id, sizeof(qe_firmware_info.id));
qe_firmware_info.extended_modes = firmware->extended_modes; qe_firmware_info.extended_modes = firmware->extended_modes;
memcpy(qe_firmware_info.vtraps, firmware->vtraps, memcpy(qe_firmware_info.vtraps, firmware->vtraps,
sizeof(firmware->vtraps)); sizeof(firmware->vtraps));
@ -583,8 +583,8 @@ struct qe_firmware_info *qe_get_firmware_info(void)
/* Copy the data into qe_firmware_info*/ /* Copy the data into qe_firmware_info*/
sprop = of_get_property(fw, "id", NULL); sprop = of_get_property(fw, "id", NULL);
if (sprop) if (sprop)
strncpy(qe_firmware_info.id, sprop, strlcpy(qe_firmware_info.id, sprop,
sizeof(qe_firmware_info.id) - 1); sizeof(qe_firmware_info.id));
prop = of_find_property(fw, "extended-modes", NULL); prop = of_find_property(fw, "extended-modes", NULL);
if (prop && (prop->length == sizeof(u64))) { if (prop && (prop->length == sizeof(u64))) {