leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nfp: bpf: rename ALU_OP_NEG to ALU_OP_NOT

Browse Source 
The current ALU_OP_NEG is Op encoding 0x4 for NPF ALU instruction. It is
actually performing "~B" operation which is bitwise NOT.

The using naming ALU_OP_NEG is misleading as NEG is -B which is not the
same as ~B.

Signed-off-by: Jiong Wang <jiong.wang@netronome.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jiong Wang 2017-11-01 10:38:24 -07:00 committed by David S. Miller
parent 07d3c4afc5
commit 5d42ced195
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/netronome/nfp/bpf/jit.c
View File

@ -944,7 +944,7 @@ wrp_alu_imm(struct nfp_prog *nfp_prog, u8 dst, enum alu_op alu_op, u32 imm)
if (alu_op == ALU_OP_XOR) { if (alu_op == ALU_OP_XOR) {
if (!~imm) if (!~imm)
emit_alu(nfp_prog, reg_both(dst), reg_none(), emit_alu(nfp_prog, reg_both(dst), reg_none(),
ALU_OP_NEG, reg_b(dst)); ALU_OP_NOT, reg_b(dst));
if (!imm || !~imm) if (!imm || !~imm)
return; return;
} }

2
drivers/net/ethernet/netronome/nfp/nfp_asm.h
View File

@ -174,7 +174,7 @@ enum shf_sc {
enum alu_op { enum alu_op {
ALU_OP_NONE = 0x00, ALU_OP_NONE = 0x00,
ALU_OP_ADD = 0x01, ALU_OP_ADD = 0x01,
ALU_OP_NEG = 0x04, ALU_OP_NOT = 0x04,
ALU_OP_AND = 0x08, ALU_OP_AND = 0x08,
ALU_OP_SUB_C = 0x0d, ALU_OP_SUB_C = 0x0d,
ALU_OP_ADD_C = 0x11, ALU_OP_ADD_C = 0x11,