leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hwmon: (it87) Simplify error return in it87_device_add

Browse Source 
Return directly on errors if there is no cleanup necessary.
Don't create an error message on memory allocation errors.

Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Guenter Roeck 2015-03-28 07:44:59 -07:00
parent 60878bcfd3
commit 5cae84a58e
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/hwmon/it87.c
View File

@ -2898,14 +2898,11 @@ static int __init it87_device_add(unsigned short address,
err = acpi_check_resource_conflict(&res);
if (err)
goto exit;
return err;
pdev = platform_device_alloc(DRVNAME, address);
if (!pdev) {
err = -ENOMEM;
pr_err("Device allocation failed\n");
goto exit;
}
if (!pdev)
return -ENOMEM;
err = platform_device_add_resources(pdev, &res, 1);
if (err) {
@ -2930,7 +2927,6 @@ static int __init it87_device_add(unsigned short address,
exit_device_put:
platform_device_put(pdev);
exit:
return err;
}