leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mmc_test: change simple_strtol() to strict_strtol()

Browse Source 
It's better to use strict_strtol() to convert user's input and strictly
check it. At least it forbids to interpret wrong input as a 0 and
prevents to run all tests.

Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
Cc: <linux-mmc@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Chris Ball <cjb@laptop.org>
This commit is contained in:
Andy Shevchenko 2010-09-01 09:26:46 +03:00 committed by Chris Ball
parent 63be54cefa
commit 5c25aee536
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/mmc/card/mmc_test.c
View File

@ -2024,9 +2024,10 @@ static ssize_t mmc_test_store(struct device *dev,
{ {
struct mmc_card *card = mmc_dev_to_card(dev); struct mmc_card *card = mmc_dev_to_card(dev);
struct mmc_test_card *test; struct mmc_test_card *test;
int testcase; long testcase;
testcase = simple_strtol(buf, NULL, 10); if (strict_strtol(buf, 10, &testcase))
return -EINVAL;
test = kzalloc(sizeof(struct mmc_test_card), GFP_KERNEL); test = kzalloc(sizeof(struct mmc_test_card), GFP_KERNEL);
if (!test) if (!test)