perf jevents: Remove jevents.c

Remove files and build rules.

Remove test for comparing with jevents.py as there is no longer a binary
to compare with.

Signed-off-by: Ian Rogers <irogers@google.com>
Tested-by: John Garry <john.garry@huawei.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ananth Narayan <ananth.narayan@amd.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Andrew Kilroy <andrew.kilroy@arm.com>
Cc: Caleb Biggers <caleb.biggers@intel.com>
Cc: Felix Fietkau <nbd@nbd.name>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@arm.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kajol Jain <kjain@linux.ibm.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Kshipra Bopardikar <kshipra.bopardikar@intel.com>
Cc: Like Xu <likexu@tencent.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Nick Forrington <nick.forrington@arm.com>
Cc: Paul Clarke <pc@us.ibm.com>
Cc: Perry Taylor <perry.taylor@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Qi Liu <liuqi115@huawei.com>
Cc: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: Sandipan Das <sandipan.das@amd.com>
Cc: Santosh Shukla <santosh.shukla@amd.com>
Cc: Stephane Eranian <eranian@google.com>
Cc: Will Deacon <will@kernel.org>
Cc: Xing Zhengjun <zhengjun.xing@linux.intel.com>
Link: https://lore.kernel.org/r/20220629182505.406269-5-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Ian Rogers 2022-06-29 11:25:05 -07:00 committed by Arnaldo Carvalho de Melo
parent 00facc7609
commit 5a059790af
8 changed files with 2 additions and 2019 deletions

View File

@ -651,32 +651,15 @@ strip: $(PROGRAMS) $(OUTPUT)perf
PERF_IN := $(OUTPUT)perf-in.o
JEVENTS := $(OUTPUT)pmu-events/jevents
JEVENTS_IN := $(OUTPUT)pmu-events/jevents-in.o
PMU_EVENTS_IN := $(OUTPUT)pmu-events/pmu-events-in.o
export NO_JEVENTS
export JEVENTS
build := -f $(srctree)/tools/build/Makefile.build dir=. obj
$(PERF_IN): prepare FORCE
$(Q)$(MAKE) $(build)=perf
$(JEVENTS_IN): FORCE
$(Q)$(MAKE) -f $(srctree)/tools/build/Makefile.build dir=pmu-events obj=jevents
$(JEVENTS): $(JEVENTS_IN)
$(QUIET_LINK)$(HOSTCC) $(JEVENTS_IN) -o $@
JEVENTS_PY := pmu-events/jevents.py
JEVENTS_PY_TEST := pmu-events/jevents-test.sh
.PHONY: jevents-py-test
jevents-py-test: $(JEVENTS)
$(Q)$(call echo-cmd,gen)$(JEVENTS_PY_TEST) $(JEVENTS) $(JEVENTS_PY) pmu-events/arch
$(PMU_EVENTS_IN): $(JEVENTS) FORCE
$(PMU_EVENTS_IN): FORCE
$(Q)$(MAKE) -f $(srctree)/tools/build/Makefile.build dir=pmu-events obj=pmu-events
$(OUTPUT)perf: $(PERFLIBS) $(PERF_IN) $(PMU_EVENTS_IN) $(LIBTRACEEVENT_DYNAMIC_LIST)
@ -1096,7 +1079,7 @@ clean:: $(LIBTRACEEVENT)-clean $(LIBAPI)-clean $(LIBBPF)-clean $(LIBSUBCMD)-clea
$(call QUIET_CLEAN, core-objs) $(RM) $(LIBPERF_A) $(OUTPUT)perf-archive $(OUTPUT)perf-iostat $(LANG_BINDINGS)
$(Q)find $(or $(OUTPUT),.) -name '*.o' -delete -o -name '\.*.cmd' -delete -o -name '\.*.d' -delete
$(Q)$(RM) $(OUTPUT).config-detected
$(call QUIET_CLEAN, core-progs) $(RM) $(ALL_PROGRAMS) perf perf-read-vdso32 perf-read-vdsox32 $(OUTPUT)pmu-events/jevents $(OUTPUT)$(LIBJVMTI).so
$(call QUIET_CLEAN, core-progs) $(RM) $(ALL_PROGRAMS) perf perf-read-vdso32 perf-read-vdsox32 $(OUTPUT)$(LIBJVMTI).so
$(call QUIET_CLEAN, core-gen) $(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo $(OUTPUT)common-cmds.h TAGS tags cscope* $(OUTPUT)PERF-VERSION-FILE $(OUTPUT)FEATURE-DUMP $(OUTPUT)util/*-bison* $(OUTPUT)util/*-flex* \
$(OUTPUT)util/intel-pt-decoder/inat-tables.c \
$(OUTPUT)tests/llvm-src-{base,kbuild,prologue,relocation}.c \

View File

@ -1,7 +1,3 @@
hostprogs := jevents
jevents-y += json.o jsmn.o jevents.o
HOSTCFLAGS_jevents.o = -I$(srctree)/tools/include
pmu-events-y += pmu-events.o
JDIR = pmu-events/arch/$(SRCARCH)
JSON = $(shell [ -d $(JDIR) ] && \

View File

@ -1,33 +0,0 @@
#!/bin/sh
# SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause)
# Validate that the legacy jevents and jevents.py produce identical output.
set -e
JEVENTS="$1"
JEVENTS_PY="$2"
ARCH_PATH="$3"
JEVENTS_C_GENERATED=$(mktemp /tmp/jevents_c.XXXXX.c)
JEVENTS_PY_GENERATED=$(mktemp /tmp/jevents_py.XXXXX.c)
cleanup() {
rm "$JEVENTS_C_GENERATED" "$JEVENTS_PY_GENERATED"
trap - exit term int
}
trap cleanup exit term int
for path in "$ARCH_PATH"/*
do
arch=$(basename $path)
if [ "$arch" = "test" ]
then
continue
fi
echo "Checking architecture: $arch"
echo "Generating using jevents.c"
"$JEVENTS" "$arch" "$ARCH_PATH" "$JEVENTS_C_GENERATED"
echo "Generating using jevents.py"
"$JEVENTS_PY" "$arch" "$ARCH_PATH" "$JEVENTS_PY_GENERATED"
echo "Diffing"
diff -u "$JEVENTS_C_GENERATED" "$JEVENTS_PY_GENERATED"
done
cleanup

File diff suppressed because it is too large Load Diff

View File

@ -1,352 +0,0 @@
/*
* Copyright (c) 2010 Serge A. Zaitsev
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE.
*
* Slightly modified by AK to not assume 0 terminated input.
*/
#include <stdlib.h>
#include "jsmn.h"
#define JSMN_STRICT
/*
* Allocates a fresh unused token from the token pool.
*/
static jsmntok_t *jsmn_alloc_token(jsmn_parser *parser,
jsmntok_t *tokens, size_t num_tokens)
{
jsmntok_t *tok;
if ((unsigned)parser->toknext >= num_tokens)
return NULL;
tok = &tokens[parser->toknext++];
tok->start = tok->end = -1;
tok->size = 0;
return tok;
}
/*
* Fills token type and boundaries.
*/
static void jsmn_fill_token(jsmntok_t *token, jsmntype_t type,
int start, int end)
{
token->type = type;
token->start = start;
token->end = end;
token->size = 0;
}
/*
* Fills next available token with JSON primitive.
*/
static jsmnerr_t jsmn_parse_primitive(jsmn_parser *parser, const char *js,
size_t len,
jsmntok_t *tokens, size_t num_tokens)
{
jsmntok_t *token;
int start;
start = parser->pos;
for (; parser->pos < len; parser->pos++) {
switch (js[parser->pos]) {
#ifndef JSMN_STRICT
/*
* In strict mode primitive must be followed by ","
* or "}" or "]"
*/
case ':':
#endif
case '\t':
case '\r':
case '\n':
case ' ':
case ',':
case ']':
case '}':
goto found;
default:
break;
}
if (js[parser->pos] < 32 || js[parser->pos] >= 127) {
parser->pos = start;
return JSMN_ERROR_INVAL;
}
}
#ifdef JSMN_STRICT
/*
* In strict mode primitive must be followed by a
* comma/object/array.
*/
parser->pos = start;
return JSMN_ERROR_PART;
#endif
found:
token = jsmn_alloc_token(parser, tokens, num_tokens);
if (token == NULL) {
parser->pos = start;
return JSMN_ERROR_NOMEM;
}
jsmn_fill_token(token, JSMN_PRIMITIVE, start, parser->pos);
parser->pos--; /* parent sees closing brackets */
return JSMN_SUCCESS;
}
/*
* Fills next token with JSON string.
*/
static jsmnerr_t jsmn_parse_string(jsmn_parser *parser, const char *js,
size_t len,
jsmntok_t *tokens, size_t num_tokens)
{
jsmntok_t *token;
int start = parser->pos;
/* Skip starting quote */
parser->pos++;
for (; parser->pos < len; parser->pos++) {
char c = js[parser->pos];
/* Quote: end of string */
if (c == '\"') {
token = jsmn_alloc_token(parser, tokens, num_tokens);
if (token == NULL) {
parser->pos = start;
return JSMN_ERROR_NOMEM;
}
jsmn_fill_token(token, JSMN_STRING, start+1,
parser->pos);
return JSMN_SUCCESS;
}
/* Backslash: Quoted symbol expected */
if (c == '\\') {
parser->pos++;
switch (js[parser->pos]) {
/* Allowed escaped symbols */
case '\"':
case '/':
case '\\':
case 'b':
case 'f':
case 'r':
case 'n':
case 't':
break;
/* Allows escaped symbol \uXXXX */
case 'u':
/* TODO */
break;
/* Unexpected symbol */
default:
parser->pos = start;
return JSMN_ERROR_INVAL;
}
}
}
parser->pos = start;
return JSMN_ERROR_PART;
}
/*
* Parse JSON string and fill tokens.
*/
jsmnerr_t jsmn_parse(jsmn_parser *parser, const char *js, size_t len,
jsmntok_t *tokens, unsigned int num_tokens)
{
jsmnerr_t r;
int i;
jsmntok_t *token;
#ifdef JSMN_STRICT
/*
* Keeps track of whether a new object/list/primitive is expected. New items are only
* allowed after an opening brace, comma or colon. A closing brace after a comma is not
* valid JSON.
*/
int expecting_item = 1;
#endif
for (; parser->pos < len; parser->pos++) {
char c;
jsmntype_t type;
c = js[parser->pos];
switch (c) {
case '{':
case '[':
#ifdef JSMN_STRICT
if (!expecting_item)
return JSMN_ERROR_INVAL;
#endif
token = jsmn_alloc_token(parser, tokens, num_tokens);
if (token == NULL)
return JSMN_ERROR_NOMEM;
if (parser->toksuper != -1)
tokens[parser->toksuper].size++;
token->type = (c == '{' ? JSMN_OBJECT : JSMN_ARRAY);
token->start = parser->pos;
parser->toksuper = parser->toknext - 1;
break;
case '}':
case ']':
#ifdef JSMN_STRICT
if (expecting_item)
return JSMN_ERROR_INVAL;
#endif
type = (c == '}' ? JSMN_OBJECT : JSMN_ARRAY);
for (i = parser->toknext - 1; i >= 0; i--) {
token = &tokens[i];
if (token->start != -1 && token->end == -1) {
if (token->type != type)
return JSMN_ERROR_INVAL;
parser->toksuper = -1;
token->end = parser->pos + 1;
break;
}
}
/* Error if unmatched closing bracket */
if (i == -1)
return JSMN_ERROR_INVAL;
for (; i >= 0; i--) {
token = &tokens[i];
if (token->start != -1 && token->end == -1) {
parser->toksuper = i;
break;
}
}
break;
case '\"':
#ifdef JSMN_STRICT
if (!expecting_item)
return JSMN_ERROR_INVAL;
expecting_item = 0;
#endif
r = jsmn_parse_string(parser, js, len, tokens,
num_tokens);
if (r < 0)
return r;
if (parser->toksuper != -1)
tokens[parser->toksuper].size++;
break;
case '\t':
case '\r':
case '\n':
case ' ':
break;
#ifdef JSMN_STRICT
case ':':
case ',':
if (expecting_item)
return JSMN_ERROR_INVAL;
expecting_item = 1;
break;
/*
* In strict mode primitives are:
* numbers and booleans.
*/
case '-':
case '0':
case '1':
case '2':
case '3':
case '4':
case '5':
case '6':
case '7':
case '8':
case '9':
case 't':
case 'f':
case 'n':
#else
case ':':
case ',':
break;
/*
* In non-strict mode every unquoted value
* is a primitive.
*/
/*FALL THROUGH */
default:
#endif
#ifdef JSMN_STRICT
if (!expecting_item)
return JSMN_ERROR_INVAL;
expecting_item = 0;
#endif
r = jsmn_parse_primitive(parser, js, len, tokens,
num_tokens);
if (r < 0)
return r;
if (parser->toksuper != -1)
tokens[parser->toksuper].size++;
break;
#ifdef JSMN_STRICT
/* Unexpected char in strict mode */
default:
return JSMN_ERROR_INVAL;
#endif
}
}
for (i = parser->toknext - 1; i >= 0; i--) {
/* Unmatched opened object or array */
if (tokens[i].start != -1 && tokens[i].end == -1)
return JSMN_ERROR_PART;
}
#ifdef JSMN_STRICT
return expecting_item ? JSMN_ERROR_INVAL : JSMN_SUCCESS;
#else
return JSMN_SUCCESS;
#endif
}
/*
* Creates a new parser based over a given buffer with an array of tokens
* available.
*/
void jsmn_init(jsmn_parser *parser)
{
parser->pos = 0;
parser->toknext = 0;
parser->toksuper = -1;
}
const char *jsmn_strerror(jsmnerr_t err)
{
switch (err) {
case JSMN_ERROR_NOMEM:
return "No enough tokens";
case JSMN_ERROR_INVAL:
return "Invalid character inside JSON string";
case JSMN_ERROR_PART:
return "The string is not a full JSON packet, more bytes expected";
case JSMN_SUCCESS:
return "Success";
default:
return "Unknown json error";
}
}

View File

@ -1,68 +0,0 @@
/* SPDX-License-Identifier: MIT */
#ifndef __JSMN_H_
#define __JSMN_H_
/*
* JSON type identifier. Basic types are:
* o Object
* o Array
* o String
* o Other primitive: number, boolean (true/false) or null
*/
typedef enum {
JSMN_PRIMITIVE = 0,
JSMN_OBJECT = 1,
JSMN_ARRAY = 2,
JSMN_STRING = 3
} jsmntype_t;
typedef enum {
/* Not enough tokens were provided */
JSMN_ERROR_NOMEM = -1,
/* Invalid character inside JSON string */
JSMN_ERROR_INVAL = -2,
/* The string is not a full JSON packet, more bytes expected */
JSMN_ERROR_PART = -3,
/* Everything was fine */
JSMN_SUCCESS = 0
} jsmnerr_t;
/*
* JSON token description.
* @param type type (object, array, string etc.)
* @param start start position in JSON data string
* @param end end position in JSON data string
*/
typedef struct {
jsmntype_t type;
int start;
int end;
int size;
} jsmntok_t;
/*
* JSON parser. Contains an array of token blocks available. Also stores
* the string being parsed now and current position in that string
*/
typedef struct {
unsigned int pos; /* offset in the JSON string */
int toknext; /* next token to allocate */
int toksuper; /* superior token node, e.g parent object or array */
} jsmn_parser;
/*
* Create JSON parser over an array of tokens
*/
void jsmn_init(jsmn_parser *parser);
/*
* Run JSON parser. It parses a JSON data string into and array of tokens,
* each describing a single JSON object.
*/
jsmnerr_t jsmn_parse(jsmn_parser *parser, const char *js,
size_t len,
jsmntok_t *tokens, unsigned int num_tokens);
const char *jsmn_strerror(jsmnerr_t err);
#endif /* __JSMN_H_ */

View File

@ -1,162 +0,0 @@
/* Parse JSON files using the JSMN parser. */
/*
* Copyright (c) 2014, Intel Corporation
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:
*
* 1. Redistributions of source code must retain the above copyright notice,
* this list of conditions and the following disclaimer.
*
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
* FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
* COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT,
* INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
* (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
* STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
* OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#include <stdlib.h>
#include <string.h>
#include <sys/mman.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <stdio.h>
#include <errno.h>
#include <unistd.h>
#include "jsmn.h"
#include "json.h"
#include <linux/kernel.h>
static char *mapfile(const char *fn, size_t *size)
{
unsigned ps = sysconf(_SC_PAGESIZE);
struct stat st;
char *map = NULL;
int err;
int fd = open(fn, O_RDONLY);
if (fd < 0 && verbose > 0 && fn) {
pr_err("Error opening events file '%s': %s\n", fn,
strerror(errno));
}
if (fd < 0)
return NULL;
err = fstat(fd, &st);
if (err < 0)
goto out;
*size = st.st_size;
map = mmap(NULL,
(st.st_size + ps - 1) & ~(ps - 1),
PROT_READ|PROT_WRITE, MAP_PRIVATE, fd, 0);
if (map == MAP_FAILED)
map = NULL;
out:
close(fd);
return map;
}
static void unmapfile(char *map, size_t size)
{
unsigned ps = sysconf(_SC_PAGESIZE);
munmap(map, roundup(size, ps));
}
/*
* Parse json file using jsmn. Return array of tokens,
* and mapped file. Caller needs to free array.
*/
jsmntok_t *parse_json(const char *fn, char **map, size_t *size, int *len)
{
jsmn_parser parser;
jsmntok_t *tokens;
jsmnerr_t res;
unsigned sz;
*map = mapfile(fn, size);
if (!*map)
return NULL;
/* Heuristic */
sz = *size * 16;
tokens = malloc(sz);
if (!tokens)
goto error;
jsmn_init(&parser);
res = jsmn_parse(&parser, *map, *size, tokens,
sz / sizeof(jsmntok_t));
if (res != JSMN_SUCCESS) {
pr_err("%s: json error %s\n", fn, jsmn_strerror(res));
goto error_free;
}
if (len)
*len = parser.toknext;
return tokens;
error_free:
free(tokens);
error:
unmapfile(*map, *size);
return NULL;
}
void free_json(char *map, size_t size, jsmntok_t *tokens)
{
free(tokens);
unmapfile(map, size);
}
static int countchar(char *map, char c, int end)
{
int i;
int count = 0;
for (i = 0; i < end; i++)
if (map[i] == c)
count++;
return count;
}
/* Return line number of a jsmn token */
int json_line(char *map, jsmntok_t *t)
{
return countchar(map, '\n', t->start) + 1;
}
static const char * const jsmn_types[] = {
[JSMN_PRIMITIVE] = "primitive",
[JSMN_ARRAY] = "array",
[JSMN_OBJECT] = "object",
[JSMN_STRING] = "string"
};
#define LOOKUP(a, i) ((i) < (sizeof(a)/sizeof(*(a))) ? ((a)[i]) : "?")
/* Return type name of a jsmn token */
const char *json_name(jsmntok_t *t)
{
return LOOKUP(jsmn_types, t->type);
}
int json_len(jsmntok_t *t)
{
return t->end - t->start;
}
/* Is string t equal to s? */
int json_streq(char *map, jsmntok_t *t, const char *s)
{
unsigned len = json_len(t);
return len == strlen(s) && !strncasecmp(map + t->start, s, len);
}

View File

@ -1,39 +0,0 @@
/* SPDX-License-Identifier: GPL-2.0 */
#ifndef JSON_H
#define JSON_H 1
#include "jsmn.h"
jsmntok_t *parse_json(const char *fn, char **map, size_t *size, int *len);
void free_json(char *map, size_t size, jsmntok_t *tokens);
int json_line(char *map, jsmntok_t *t);
const char *json_name(jsmntok_t *t);
int json_streq(char *map, jsmntok_t *t, const char *s);
int json_len(jsmntok_t *t);
extern int verbose;
#include <stdbool.h>
extern int eprintf(int level, int var, const char *fmt, ...);
#define pr_fmt(fmt) fmt
#define pr_err(fmt, ...) \
eprintf(0, verbose, pr_fmt(fmt), ##__VA_ARGS__)
#define pr_info(fmt, ...) \
eprintf(1, verbose, pr_fmt(fmt), ##__VA_ARGS__)
#define pr_debug(fmt, ...) \
eprintf(2, verbose, pr_fmt(fmt), ##__VA_ARGS__)
#ifndef roundup
#define roundup(x, y) ( \
{ \
const typeof(y) __y = y; \
(((x) + (__y - 1)) / __y) * __y; \
} \
)
#endif
#endif