leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: cdc_ncm: return proper error if setup fails

Browse Source 
Most setup errors are ignored to ensure maximum firmware
compatibilty.  But GET_NTB_PARAMETERS and the functional
descriptors are required.  Use proper error codes and
log level if these fail.

Cc: Alexey Orishko <alexey.orishko@gmail.com>
Signed-off-by: Bjørn Mork <bjorn@mork.no>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Bjørn Mork 2013-11-01 11:16:59 +01:00 committed by David S. Miller
parent 47175e5f28
commit 59ede3168a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/usb/cdc_ncm.c
View File

@ -86,8 +86,8 @@ static u8 cdc_ncm_setup(struct usbnet *dev)
0, iface_no, &ncm_parm, 0, iface_no, &ncm_parm,
sizeof(ncm_parm)); sizeof(ncm_parm));
if (err < 0) { if (err < 0) {
dev_dbg(&dev->intf->dev, "failed GET_NTB_PARAMETERS\n"); dev_err(&dev->intf->dev, "failed GET_NTB_PARAMETERS\n");
return 1; return err; /* GET_NTB_PARAMETERS is required */
} }
/* read correct set of parameters according to device mode */ /* read correct set of parameters according to device mode */