forked from Minki/linux
net: ocelot: Add of_node_put() before return statement
Every iteration of for_each_available_child_of_node() decrements the reference count of the previous node, however when control is transferred from the middle of the loop, as in the case of a return or break or goto, there is no decrement thus ultimately resulting in a memory leak. Fix a potential memory leak in felix.c by inserting of_node_put() before the return statement. Issue found with Coccinelle. Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
4341b7d916
commit
59ebb4305c
@ -400,6 +400,7 @@ static int felix_parse_ports_node(struct felix *felix,
|
||||
if (err < 0) {
|
||||
dev_err(dev, "Unsupported PHY mode %s on port %d\n",
|
||||
phy_modes(phy_mode), port);
|
||||
of_node_put(child);
|
||||
return err;
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user