leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: mdio: mscc-miim: replace magic numbers for the bus reset

Browse Source 
Replace the magic numbers by macros which are already defined. It seems
the original commit missed to use them.

Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Michael Walle 2022-03-18 21:13:23 +01:00 committed by Jakub Kicinski
parent a2e4b5adfd
commit 58ebdba3d8
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/net/mdio/mdio-mscc-miim.c
View File

@ -158,18 +158,18 @@ static int mscc_miim_reset(struct mii_bus *bus)
{ {
struct mscc_miim_dev *miim = bus->priv; struct mscc_miim_dev *miim = bus->priv;
int offset = miim->phy_reset_offset; int offset = miim->phy_reset_offset;
int reset_bits = PHY_CFG_PHY_ENA | PHY_CFG_PHY_COMMON_RESET |
PHY_CFG_PHY_RESET;
int ret; int ret;
if (miim->phy_regs) { if (miim->phy_regs) {
ret = regmap_write(miim->phy_regs, ret = regmap_write(miim->phy_regs, offset, 0);
MSCC_PHY_REG_PHY_CFG + offset, 0);
if (ret < 0) { if (ret < 0) {
WARN_ONCE(1, "mscc reset set error %d\n", ret); WARN_ONCE(1, "mscc reset set error %d\n", ret);
return ret; return ret;
} }
ret = regmap_write(miim->phy_regs, ret = regmap_write(miim->phy_regs, offset, reset_bits);
MSCC_PHY_REG_PHY_CFG + offset, 0x1ff);
if (ret < 0) { if (ret < 0) {
WARN_ONCE(1, "mscc reset clear error %d\n", ret); WARN_ONCE(1, "mscc reset clear error %d\n", ret);
return ret; return ret;
@ -272,7 +272,7 @@ static int mscc_miim_probe(struct platform_device *pdev)
miim = bus->priv; miim = bus->priv;
miim->phy_regs = phy_regmap; miim->phy_regs = phy_regmap;
miim->phy_reset_offset = 0; miim->phy_reset_offset = MSCC_PHY_REG_PHY_CFG;
ret = of_mdiobus_register(bus, pdev->dev.of_node); ret = of_mdiobus_register(bus, pdev->dev.of_node);
if (ret < 0) { if (ret < 0) {