leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ceph: use dedicated list iterator variable

Browse Source 
To move the list iterator variable into the list_for_each_entry_*()
macro in the future it should be avoided to use the list iterator
variable after the loop body.

To *never* use the list iterator variable after the loop it was
concluded to use a separate iterator variable.

Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
This commit is contained in:
Jakob Koschel 2022-03-31 23:53:28 +02:00 committed by Ilya Dryomov
parent 7ffe4fcea7
commit 57a5df0e86
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
fs/ceph/caps.c
View File

@ -1577,7 +1577,7 @@ static void __ceph_flush_snaps(struct ceph_inode_info *ci,
while (first_tid <= last_tid) { while (first_tid <= last_tid) {
struct ceph_cap *cap = ci->i_auth_cap; struct ceph_cap *cap = ci->i_auth_cap;
struct ceph_cap_flush *cf; struct ceph_cap_flush *cf = NULL, *iter;
int ret; int ret;
if (!(cap && cap->session == session)) { if (!(cap && cap->session == session)) {
@ -1587,8 +1587,9 @@ static void __ceph_flush_snaps(struct ceph_inode_info *ci,
} }
ret = -ENOENT; ret = -ENOENT;
list_for_each_entry(cf, &ci->i_cap_flush_list, i_list) { list_for_each_entry(iter, &ci->i_cap_flush_list, i_list) {
if (cf->tid >= first_tid) { if (iter->tid >= first_tid) {
cf = iter;
ret = 0; ret = 0;
break; break;
} }