leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drm/i915: Decrease number of subplatform bits

Browse Source 
Commit 6ce1c33d6c ("drm/i915: Kill INTEL_SUBPLATFORM_AML") removed the
only platform which used bit 2 so could also decrease the
INTEL_SUBPLATFORM_BITS definition.

This is not a fixes material but still lets make it precise.

v2:
 * Fix assert in intel_device_info_subplatform_init by introducing
   INTEL_SUBPLATFORM_MASK. (Chris)
 * Update intel_subplatform().

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
References: 6ce1c33d6c ("drm/i915: Kill INTEL_SUBPLATFORM_AML")
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20210121161936.746591-2-tvrtko.ursulin@linux.intel.com
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
This commit is contained in:
Tvrtko Ursulin 2021-01-21 16:19:36 +00:00 committed by Daniel Vetter
parent 536f77b1ca
commit 56afa70151
3 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpu/drm/i915/i915_drv.h
View File

@ -1298,7 +1298,7 @@ intel_subplatform(const struct intel_runtime_info *info, enum intel_platform p)
{ {
const unsigned int pi = __platform_mask_index(info, p); const unsigned int pi = __platform_mask_index(info, p);
return info->platform_mask[pi] & ((1 << INTEL_SUBPLATFORM_BITS) - 1); return info->platform_mask[pi] & INTEL_SUBPLATFORM_MASK;
} }
static __always_inline bool static __always_inline bool

2
drivers/gpu/drm/i915/intel_device_info.c
View File

@ -223,7 +223,7 @@ void intel_device_info_subplatform_init(struct drm_i915_private *i915)
} }
} }
GEM_BUG_ON(mask & ~INTEL_SUBPLATFORM_BITS); GEM_BUG_ON(mask & ~INTEL_SUBPLATFORM_MASK);
RUNTIME_INFO(i915)->platform_mask[pi] |= mask; RUNTIME_INFO(i915)->platform_mask[pi] |= mask;
} }

3
drivers/gpu/drm/i915/intel_device_info.h
View File

@ -93,7 +93,8 @@ enum intel_platform {
* it is fine for the same bit to be used on multiple parent platforms. * it is fine for the same bit to be used on multiple parent platforms.
*/ */
#define INTEL_SUBPLATFORM_BITS (3) #define INTEL_SUBPLATFORM_BITS (2)
#define INTEL_SUBPLATFORM_MASK (BIT(INTEL_SUBPLATFORM_BITS) - 1)
/* HSW/BDW/SKL/KBL/CFL */ /* HSW/BDW/SKL/KBL/CFL */
#define INTEL_SUBPLATFORM_ULT (0) #define INTEL_SUBPLATFORM_ULT (0)