leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[PATCH] hostap: Fix ap_add_sta() return value verification

Browse Source 
The Coverity checker (CID: 273) spotted this inconsequent NULL checking
(unconditionally dereferencing directly after checking for NULL
isn't a good idea). Return immediately to avoid this.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Jouni Malinen <jkmaline@cc.hut.fi>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Adrian Bunk 2006-03-19 19:21:45 -08:00 committed by John W. Linville
parent 971d1e6922
commit 54b85f489b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/wireless/hostap/hostap_ap.c
View File

@ -3141,7 +3141,7 @@ int hostap_add_sta(struct ap_data *ap, u8 *sta_addr)
if (ret == 1) { if (ret == 1) {
sta = ap_add_sta(ap, sta_addr); sta = ap_add_sta(ap, sta_addr);
if (!sta) if (!sta)
ret = -1; return -1;
sta->flags = WLAN_STA_AUTH | WLAN_STA_ASSOC; sta->flags = WLAN_STA_AUTH | WLAN_STA_ASSOC;
sta->ap = 1; sta->ap = 1;
memset(sta->supported_rates, 0, sizeof(sta->supported_rates)); memset(sta->supported_rates, 0, sizeof(sta->supported_rates));