leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drm/i915: fix the __intel_fbc_update() comments

Browse Source 
Don't try to list in comments the cases where we should enable or
disable FBC: it varies a lot with the hardware generations and the
code should be the documentation. Also notice that there's already a
huge gap between the comments and what's in the code.

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

Link: http://patchwork.freedesktop.org/patch/msgid/1446664257-32012-7-git-send-email-paulo.r.zanoni@intel.com
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
This commit is contained in:
Paulo Zanoni 2015-11-04 17:10:50 -02:00 committed by Maarten Lankhorst
parent 45b32a2919
commit 548043abae
1 changed files with 2 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
drivers/gpu/drm/i915/intel_fbc.c
View File

@ -806,20 +806,8 @@ static bool intel_fbc_hw_tracking_covers_screen(struct intel_crtc *crtc)
* __intel_fbc_update - enable/disable FBC as needed, unlocked * __intel_fbc_update - enable/disable FBC as needed, unlocked
* @dev_priv: i915 device instance * @dev_priv: i915 device instance
* *
* Set up the framebuffer compression hardware at mode set time. We * This function completely reevaluates the status of FBC, then enables,
* enable it if possible: * disables or maintains it on the same state.
* - plane A only (on pre-965)
* - no pixel mulitply/line duplication
* - no alpha buffer discard
* - no dual wide
* - framebuffer <= max_hdisplay in width, max_vdisplay in height
*
* We can't assume that any compression will take place (worst case),
* so the compressed buffer has to be the same size as the uncompressed
* one. It also must reside (along with the line length buffer) in
* stolen memory.
*
* We need to enable/disable FBC on a global basis.
*/ */
static void __intel_fbc_update(struct drm_i915_private *dev_priv) static void __intel_fbc_update(struct drm_i915_private *dev_priv)
{ {
@ -831,7 +819,6 @@ static void __intel_fbc_update(struct drm_i915_private *dev_priv)
WARN_ON(!mutex_is_locked(&dev_priv->fbc.lock)); WARN_ON(!mutex_is_locked(&dev_priv->fbc.lock));
/* disable framebuffer compression in vGPU */
if (intel_vgpu_active(dev_priv->dev)) if (intel_vgpu_active(dev_priv->dev))
i915.enable_fbc = 0; i915.enable_fbc = 0;
@ -845,15 +832,6 @@ static void __intel_fbc_update(struct drm_i915_private *dev_priv)
goto out_disable; goto out_disable;
} }
/*
* If FBC is already on, we just have to verify that we can
* keep it that way...
* Need to disable if:
* - more than one pipe is active
* - changing FBC params (stride, fence, mode)
* - new fb is too large to fit in compressed buffer
* - going to an unsupported config (interlace, pixel multiply, etc.)
*/
drm_crtc = intel_fbc_find_crtc(dev_priv); drm_crtc = intel_fbc_find_crtc(dev_priv);
if (!drm_crtc) { if (!drm_crtc) {
set_no_fbc_reason(dev_priv, "no output"); set_no_fbc_reason(dev_priv, "no output");