leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

igb: remove duplicate code for fallback interrupt initialization

Browse Source 
Given a small change to igb_init_interrupt_scheme() the function fits
igb_request_irq() for MSI/legacy interrupts initialization as well, instead of
duplicating most of its code there.

Also adding a missing igb_configure() to igb_request_irq() for MSI fallback
to work properly.

Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
This commit is contained in:
Stefan Assmann
2012-12-04 06:00:12 +00:00
committed by Jeff Kirsher
parent cb6d0f5eef
commit 53c7d06418
1 changed files with 14 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
drivers/net/ethernet/intel/igb/igb_main.c
View File

@@ -122,6 +122,7 @@ static void igb_remove(struct pci_dev *pdev);
static int igb_sw_init(struct igb_adapter *); static int igb_sw_init(struct igb_adapter *);
static int igb_open(struct net_device *); static int igb_open(struct net_device *);
static int igb_close(struct net_device *); static int igb_close(struct net_device *);
static void igb_configure(struct igb_adapter *);
static void igb_configure_tx(struct igb_adapter *); static void igb_configure_tx(struct igb_adapter *);
static void igb_configure_rx(struct igb_adapter *); static void igb_configure_rx(struct igb_adapter *);
static void igb_clean_all_tx_rings(struct igb_adapter *); static void igb_clean_all_tx_rings(struct igb_adapter *);
@@ -948,11 +949,14 @@ static void igb_clear_interrupt_scheme(struct igb_adapter *adapter)
* Attempt to configure interrupts using the best available * Attempt to configure interrupts using the best available
* capabilities of the hardware and kernel. * capabilities of the hardware and kernel.
**/ **/
static void igb_set_interrupt_capability(struct igb_adapter *adapter) static void igb_set_interrupt_capability(struct igb_adapter *adapter, bool msix)
{ {
int err; int err;
int numvecs, i; int numvecs, i;
if (!msix)
goto msi_only;
/* Number of supported queues. */ /* Number of supported queues. */
adapter->num_rx_queues = adapter->rss_queues; adapter->num_rx_queues = adapter->rss_queues;
if (adapter->vfs_allocated_count) if (adapter->vfs_allocated_count)
@@ -1199,12 +1203,12 @@ err_out:
* *
* This function initializes the interrupts and allocates all of the queues. * This function initializes the interrupts and allocates all of the queues.
**/ **/
static int igb_init_interrupt_scheme(struct igb_adapter *adapter) static int igb_init_interrupt_scheme(struct igb_adapter *adapter, bool msix)
{ {
struct pci_dev *pdev = adapter->pdev; struct pci_dev *pdev = adapter->pdev;
int err; int err;
igb_set_interrupt_capability(adapter); igb_set_interrupt_capability(adapter, msix);
err = igb_alloc_q_vectors(adapter); err = igb_alloc_q_vectors(adapter);
if (err) { if (err) {
@@ -1240,20 +1244,15 @@ static int igb_request_irq(struct igb_adapter *adapter)
/* fall back to MSI */ /* fall back to MSI */
igb_free_all_tx_resources(adapter); igb_free_all_tx_resources(adapter);
igb_free_all_rx_resources(adapter); igb_free_all_rx_resources(adapter);
igb_clear_interrupt_scheme(adapter); igb_clear_interrupt_scheme(adapter);
if (!pci_enable_msi(pdev)) err = igb_init_interrupt_scheme(adapter, false);
adapter->flags |= IGB_FLAG_HAS_MSI; if (err)
adapter->num_tx_queues = 1;
adapter->num_rx_queues = 1;
adapter->num_q_vectors = 1;
err = igb_alloc_q_vectors(adapter);
if (err) {
dev_err(&pdev->dev,
"Unable to allocate memory for vectors\n");
goto request_done; goto request_done;
}
igb_setup_all_tx_resources(adapter); igb_setup_all_tx_resources(adapter);
igb_setup_all_rx_resources(adapter); igb_setup_all_rx_resources(adapter);
igb_configure(adapter);
} }
igb_assign_vector(adapter->q_vector[0], 0); igb_assign_vector(adapter->q_vector[0], 0);
@@ -2444,7 +2443,7 @@ static int igb_sw_init(struct igb_adapter *adapter)
GFP_ATOMIC); GFP_ATOMIC);
/* This call may decrease the number of queues */ /* This call may decrease the number of queues */
if (igb_init_interrupt_scheme(adapter)) { if (igb_init_interrupt_scheme(adapter, true)) {
dev_err(&pdev->dev, "Unable to allocate memory for queues\n"); dev_err(&pdev->dev, "Unable to allocate memory for queues\n");
return -ENOMEM; return -ENOMEM;
} }
@@ -6818,7 +6817,7 @@ static int igb_resume(struct device *dev)
pci_enable_wake(pdev, PCI_D3hot, 0); pci_enable_wake(pdev, PCI_D3hot, 0);
pci_enable_wake(pdev, PCI_D3cold, 0); pci_enable_wake(pdev, PCI_D3cold, 0);
if (igb_init_interrupt_scheme(adapter)) { if (igb_init_interrupt_scheme(adapter, true)) {
dev_err(&pdev->dev, "Unable to allocate memory for queues\n"); dev_err(&pdev->dev, "Unable to allocate memory for queues\n");
return -ENOMEM; return -ENOMEM;
} }