leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

workqueue: use put_device() instead of kfree()

Browse Source 
Never directly free @dev after calling device_register(), even
if it returned an error! Always use put_device() to give up the
reference initialized in this function instead.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
This commit is contained in:
Arvind Yadav 2018-03-06 15:35:43 +05:30 committed by Tejun Heo
parent fc6eabbbf8
commit 537f4146c5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
kernel/workqueue.c
View File

@ -5337,7 +5337,7 @@ int workqueue_sysfs_register(struct workqueue_struct *wq)
ret = device_register(&wq_dev->dev); ret = device_register(&wq_dev->dev);
if (ret) { if (ret) {
kfree(wq_dev); put_device(&wq_dev->dev);
wq->wq_dev = NULL; wq->wq_dev = NULL;
return ret; return ret;
} }