leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[SCSI] bfa: Fix to set correct return error codes and misc cleanup.

Browse Source 
- Remove unnecessary if NULL check in function bfa_fcs_vport_free().
- Set correct return error codes in case of memory allocation failure
  in the BSG ELS/CT passthru command handler.

Signed-off-by: Krishna Gudipati <kgudipat@brocade.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
This commit is contained in:
Krishna Gudipati 2012-07-13 16:08:22 -07:00 committed by James Bottomley
parent 85d22bbf67
commit 529f9a7655
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/scsi/bfa/bfa_fcs_lport.c
View File

@ -5722,9 +5722,7 @@ bfa_fcs_vport_free(struct bfa_fcs_vport_s *vport)
* The memory for the bfad_vport_s is freed from the FC function * The memory for the bfad_vport_s is freed from the FC function
* template vport_delete entry point. * template vport_delete entry point.
*/ */
if (vport_drv) bfad_im_port_delete(vport_drv->drv_port.bfad, &vport_drv->drv_port);
bfad_im_port_delete(vport_drv->drv_port.bfad,
&vport_drv->drv_port);
} }
/* /*

5
drivers/scsi/bfa/bfad_bsg.c
View File

@ -3008,12 +3008,15 @@ bfad_im_bsg_els_ct_request(struct fc_bsg_job *job)
* buffer of size bsg_data->payload_len * buffer of size bsg_data->payload_len
*/ */
bsg_fcpt = kzalloc(bsg_data->payload_len, GFP_KERNEL); bsg_fcpt = kzalloc(bsg_data->payload_len, GFP_KERNEL);
if (!bsg_fcpt) if (!bsg_fcpt) {
rc = -ENOMEM;
goto out; goto out;
}
if (copy_from_user((uint8_t *)bsg_fcpt, bsg_data->payload, if (copy_from_user((uint8_t *)bsg_fcpt, bsg_data->payload,
bsg_data->payload_len)) { bsg_data->payload_len)) {
kfree(bsg_fcpt); kfree(bsg_fcpt);
rc = -EIO;
goto out; goto out;
} }