leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

qed: Fix static checker warnings.

Browse Source 
Static checker warnings:
drivers/net/ethernet/qlogic/qed/qed_int.c:2450 qed_init_cau_sb_entry()
warn: always true condition '(cdev->rx_coalesce_usecs <= 255) =>
(0-255 <= 255)'
drivers/net/ethernet/qlogic/qed/qed_int.c:2511 qed_int_cau_conf_sb()
warn: always true condition '(p_hwfn->cdev->rx_coalesce_usecs <= 255)
=> (0-255 <= 255)'
..

The data types for rx/tx_coalesce_usecs should be u16.

Fixes: commit 722003ac40 ("qed: Add support for coalescing config read/update.")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sudarsana Reddy Kalluru <sudarsana.kalluru@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Sudarsana Reddy Kalluru 2016-06-28 02:10:58 -04:00 committed by David S. Miller
parent fb773e975e
commit 51d9988087
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/ethernet/qlogic/qed/qed.h
View File

@ -489,8 +489,8 @@ struct qed_dev {
u32 int_mode; u32 int_mode;
enum qed_coalescing_mode int_coalescing_mode; enum qed_coalescing_mode int_coalescing_mode;
u8 rx_coalesce_usecs; u16 rx_coalesce_usecs;
u8 tx_coalesce_usecs; u16 tx_coalesce_usecs;
/* Start Bar offset of first hwfn */ /* Start Bar offset of first hwfn */
void __iomem *regview; void __iomem *regview;